aspectran / aspectran / #4657

44%

Build Type

push

github

Committed by topframe

Commit Message

feat(shell): Improve quit command in non-interactive mode

The 'quit' command was not suitable for scripted or piped execution. It would hang at the confirmation prompt, assuming an interactive user was present.

This commit introduces non-interactive mode awareness to the shell, leading to the following improvements for the 'quit' command:

- In non-interactive sessions (e.g., `echo "quit" | shell.bat`), the command now executes without a confirmation prompt.
- The "Bye." exit message is now suppressed in non-interactive mode for a cleaner, script-friendly output.

To achieve this, an `isInteractive()` method has been added to the `ShellConsole` interface, with distinct implementations for `JLineShellConsole` (interactive) and `DefaultShellConsole` (non-interactive).

Additionally, `DefaultShellConsole`'s input handling has been made more robust to prevent potential infinite loops when an input stream is closed.

Run Details

0 of 13 new or added lines in 5 files covered. (0.0%)

6 existing lines in 1 file now uncovered.

14988 of 41375 relevant lines covered (36.22%)

0.36 hits per line