18517631058

Committed 15 Oct 2025 04:18AM UTC coverage: 69.207% (-11.1%) from 80.267%

Build # 18517631058

Build Type

Pull #22745

github

Committed by

web-flow

Commit Message

Merge 642a76ca1 into 99919310e

Pull Request Pull Request #22745: [windows] Add windows support in the stdio crate.

Run Details

53815 of 77759 relevant lines covered (69.21%)

2.42 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

66.13

/src/python/pants/backend/python/lint/pyupgrade/rules_integration_test.py

# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
# Licensed under the Apache License, Version 2.0 (see LICENSE).

from __future__ import annotations

import pytest

from pants.backend.python import target_types_rules
from pants.backend.python.lint.pyupgrade.rules import PyUpgradeFieldSet, PyUpgradeRequest
from pants.backend.python.lint.pyupgrade.rules import rules as pyupgrade_rules
from pants.backend.python.lint.pyupgrade.subsystem import PyUpgrade
from pants.backend.python.lint.pyupgrade.subsystem import rules as pyupgrade_subsystem_rules
from pants.backend.python.target_types import PythonSourcesGeneratorTarget
from pants.core.goals.fix import FixResult
from pants.core.util_rules import config_files, source_files
from pants.core.util_rules.source_files import SourceFiles, SourceFilesRequest
from pants.engine.addresses import Address
from pants.engine.target import Target
from pants.testutil.python_interpreter_selection import all_major_minor_python_versions
from pants.testutil.rule_runner import QueryRule, RuleRunner


@pytest.fixture
def rule_runner() -> RuleRunner:
    return RuleRunner(
        rules=[
            *pyupgrade_rules(),
            *pyupgrade_subsystem_rules(),
            *source_files.rules(),
            *config_files.rules(),
            *target_types_rules.rules(),
            QueryRule(FixResult, (PyUpgradeRequest.Batch,)),
            QueryRule(SourceFiles, (SourceFilesRequest,)),
        ],
        target_types=[PythonSourcesGeneratorTarget],
    )


# see: https://github.com/asottile/pyupgrade#redundant-open-modes
PY_36_GOOD_FILE = "open('hello.txt')"
PY_36_BAD_FILE = "open('jerry.txt', 'r')"
PY_36_FIXED_BAD_FILE = "open('jerry.txt')"

# see: https://github.com/asottile/pyupgrade#is--is-not-comparison-to-constant-literals
PY_38_BAD_FILE = "x is 920"
PY_38_FIXED_BAD_FILE = "x == 920"


def run_pyupgrade(
    rule_runner: RuleRunner,
    targets: list[Target],
    *,
    extra_args: list[str] | None = None,
    pyupgrade_arg: str = "--py36-plus",
) -> FixResult:
    rule_runner.set_options(
        [
            "--backend-packages=pants.backend.python.lint.pyupgrade",
            f'--pyupgrade-args="{pyupgrade_arg}"',
            *(extra_args or ()),
        ],
        env_inherit={"PATH", "PYENV_ROOT", "HOME"},
    )
    field_sets = [PyUpgradeFieldSet.create(tgt) for tgt in targets]
    input_sources = rule_runner.request(
        SourceFiles,
        [
            SourceFilesRequest(field_set.source for field_set in field_sets),
        ],
    )
    fix_result = rule_runner.request(
        FixResult,
        [
            PyUpgradeRequest.Batch(
                "",
                input_sources.snapshot.files,
                partition_metadata=None,
                snapshot=input_sources.snapshot,
            ),
        ],
    )
    return fix_result


@pytest.mark.platform_specific_behavior
@pytest.mark.parametrize(
    "major_minor_interpreter",
    all_major_minor_python_versions(PyUpgrade.default_interpreter_constraints),
)
def test_passing(rule_runner: RuleRunner, major_minor_interpreter: str) -> None:
    rule_runner.write_files({"f.py": PY_36_GOOD_FILE, "BUILD": "python_sources(name='t')"})
    tgt = rule_runner.get_target(Address("", target_name="t", relative_file_path="f.py"))
    fix_result = run_pyupgrade(
        rule_runner,
        [tgt],
        extra_args=[f"--pyupgrade-interpreter-constraints=['=={major_minor_interpreter}.*']"],
    )
    assert fix_result.output == rule_runner.make_snapshot({"f.py": PY_36_GOOD_FILE})
    assert fix_result.did_change is False


def test_convergance(rule_runner: RuleRunner) -> None:
    # NB: Testing the fact that we re-run pyupgrade until it converges
    percent_s_string_formatting = '"%s %s" % (foo, bar)\n'
    rule_runner.write_files(
        {"f.py": percent_s_string_formatting, "BUILD": "python_sources(name='t')"}
    )
    tgt = rule_runner.get_target(Address("", target_name="t", relative_file_path="f.py"))
    fix_result = run_pyupgrade(rule_runner, [tgt], extra_args=["--pyupgrade-args=--py36-plus"])
    assert fix_result.output == rule_runner.make_snapshot({"f.py": 'f"{foo} {bar}"\n'})
    assert fix_result.did_change is True


def test_failing(rule_runner: RuleRunner) -> None:
    rule_runner.write_files({"f.py": PY_36_BAD_FILE, "BUILD": "python_sources(name='t')"})
    tgt = rule_runner.get_target(Address("", target_name="t", relative_file_path="f.py"))
    fix_result = run_pyupgrade(rule_runner, [tgt])
    assert fix_result.output == rule_runner.make_snapshot({"f.py": PY_36_FIXED_BAD_FILE})
    assert fix_result.did_change is True


def test_multiple_targets(rule_runner: RuleRunner) -> None:
    rule_runner.write_files(
        {"good.py": PY_36_GOOD_FILE, "bad.py": PY_36_BAD_FILE, "BUILD": "python_sources(name='t')"}
    )
    tgts = [
        rule_runner.get_target(Address("", target_name="t", relative_file_path="good.py")),
        rule_runner.get_target(Address("", target_name="t", relative_file_path="bad.py")),
    ]
    fix_result = run_pyupgrade(rule_runner, tgts)
    assert fix_result.output == rule_runner.make_snapshot(
        {"good.py": PY_36_GOOD_FILE, "bad.py": PY_36_FIXED_BAD_FILE}
    )
    assert fix_result.did_change is True


def test_passthrough_args(rule_runner: RuleRunner) -> None:
    rule_runner.write_files(
        {"some_file_name.py": PY_38_BAD_FILE, "BUILD": "python_sources(name='t')"}
    )
    tgt = rule_runner.get_target(
        Address("", target_name="t", relative_file_path="some_file_name.py")
    )
    fix_result = run_pyupgrade(
        rule_runner,
        [tgt],
        pyupgrade_arg="--py38-plus",
    )
    assert fix_result.output == rule_runner.make_snapshot(
        {"some_file_name.py": PY_38_FIXED_BAD_FILE}
    )
    assert fix_result.did_change is True

1	# Copyright 2021 Pants project contributors (see CONTRIBUTORS.md).
2	# Licensed under the Apache License, Version 2.0 (see LICENSE).
3
4	from __future__ import annotations	2✔
5
6	import pytest	2✔
7
8	from pants.backend.python import target_types_rules	2✔
9	from pants.backend.python.lint.pyupgrade.rules import PyUpgradeFieldSet, PyUpgradeRequest	2✔
10	from pants.backend.python.lint.pyupgrade.rules import rules as pyupgrade_rules	2✔
11	from pants.backend.python.lint.pyupgrade.subsystem import PyUpgrade	2✔
12	from pants.backend.python.lint.pyupgrade.subsystem import rules as pyupgrade_subsystem_rules	2✔
13	from pants.backend.python.target_types import PythonSourcesGeneratorTarget	2✔
14	from pants.core.goals.fix import FixResult	2✔
15	from pants.core.util_rules import config_files, source_files	2✔
16	from pants.core.util_rules.source_files import SourceFiles, SourceFilesRequest	2✔
17	from pants.engine.addresses import Address	2✔
18	from pants.engine.target import Target	2✔
19	from pants.testutil.python_interpreter_selection import all_major_minor_python_versions	2✔
20	from pants.testutil.rule_runner import QueryRule, RuleRunner	2✔
21
22
23	@pytest.fixture	2✔
24	def rule_runner() -> RuleRunner:	2✔
25	return RuleRunner(	2✔
26	rules=[
27	*pyupgrade_rules(),
28	*pyupgrade_subsystem_rules(),
29	*source_files.rules(),
30	*config_files.rules(),
31	*target_types_rules.rules(),
32	QueryRule(FixResult, (PyUpgradeRequest.Batch,)),
33	QueryRule(SourceFiles, (SourceFilesRequest,)),
34	],
35	target_types=[PythonSourcesGeneratorTarget],
36	)
37
38
39	# see: https://github.com/asottile/pyupgrade#redundant-open-modes
40	PY_36_GOOD_FILE = "open('hello.txt')"	2✔
41	PY_36_BAD_FILE = "open('jerry.txt', 'r')"	2✔
42	PY_36_FIXED_BAD_FILE = "open('jerry.txt')"	2✔
43
44	# see: https://github.com/asottile/pyupgrade#is--is-not-comparison-to-constant-literals
45	PY_38_BAD_FILE = "x is 920"	2✔
46	PY_38_FIXED_BAD_FILE = "x == 920"	2✔
47
48
49	def run_pyupgrade(	2✔
50	rule_runner: RuleRunner,
51	targets: list[Target],
52	*,
53	extra_args: list[str] \| None = None,
54	pyupgrade_arg: str = "--py36-plus",
55	) -> FixResult:
56	rule_runner.set_options(	2✔
57	[
58	"--backend-packages=pants.backend.python.lint.pyupgrade",
59	f'--pyupgrade-args="{pyupgrade_arg}"',
60	*(extra_args or ()),
61	],
62	env_inherit={"PATH", "PYENV_ROOT", "HOME"},
63	)
64	field_sets = [PyUpgradeFieldSet.create(tgt) for tgt in targets]	2✔
65	input_sources = rule_runner.request(	2✔
66	SourceFiles,
67	[
68	SourceFilesRequest(field_set.source for field_set in field_sets),
69	],
70	)
71	fix_result = rule_runner.request(	2✔
72	FixResult,
73	[
74	PyUpgradeRequest.Batch(
75	"",
76	input_sources.snapshot.files,
77	partition_metadata=None,
78	snapshot=input_sources.snapshot,
79	),
80	],
81	)
82	return fix_result	2✔
83
84
85	@pytest.mark.platform_specific_behavior	2✔
86	@pytest.mark.parametrize(	2✔
87	"major_minor_interpreter",
88	all_major_minor_python_versions(PyUpgrade.default_interpreter_constraints),
89	)
90	def test_passing(rule_runner: RuleRunner, major_minor_interpreter: str) -> None:	2✔
91	rule_runner.write_files({"f.py": PY_36_GOOD_FILE, "BUILD": "python_sources(name='t')"})	2✔
92	tgt = rule_runner.get_target(Address("", target_name="t", relative_file_path="f.py"))	2✔
93	fix_result = run_pyupgrade(	2✔
94	rule_runner,
95	[tgt],
96	extra_args=[f"--pyupgrade-interpreter-constraints=['=={major_minor_interpreter}.*']"],
97	)
98	assert fix_result.output == rule_runner.make_snapshot({"f.py": PY_36_GOOD_FILE})	2✔
99	assert fix_result.did_change is False	2✔
100
101
102	def test_convergance(rule_runner: RuleRunner) -> None:	2✔
103	# NB: Testing the fact that we re-run pyupgrade until it converges
104	percent_s_string_formatting = '"%s %s" % (foo, bar)\n'	×
105	rule_runner.write_files(	×
106	{"f.py": percent_s_string_formatting, "BUILD": "python_sources(name='t')"}
107	)
108	tgt = rule_runner.get_target(Address("", target_name="t", relative_file_path="f.py"))	×
109	fix_result = run_pyupgrade(rule_runner, [tgt], extra_args=["--pyupgrade-args=--py36-plus"])	×
110	assert fix_result.output == rule_runner.make_snapshot({"f.py": 'f"{foo} {bar}"\n'})	×
111	assert fix_result.did_change is True	×
112
113
114	def test_failing(rule_runner: RuleRunner) -> None:	2✔
115	rule_runner.write_files({"f.py": PY_36_BAD_FILE, "BUILD": "python_sources(name='t')"})	×
116	tgt = rule_runner.get_target(Address("", target_name="t", relative_file_path="f.py"))	×
117	fix_result = run_pyupgrade(rule_runner, [tgt])	×
118	assert fix_result.output == rule_runner.make_snapshot({"f.py": PY_36_FIXED_BAD_FILE})	×
119	assert fix_result.did_change is True	×
120
121
122	def test_multiple_targets(rule_runner: RuleRunner) -> None:	2✔
123	rule_runner.write_files(	×
124	{"good.py": PY_36_GOOD_FILE, "bad.py": PY_36_BAD_FILE, "BUILD": "python_sources(name='t')"}
125	)
126	tgts = [	×
127	rule_runner.get_target(Address("", target_name="t", relative_file_path="good.py")),
128	rule_runner.get_target(Address("", target_name="t", relative_file_path="bad.py")),
129	]
130	fix_result = run_pyupgrade(rule_runner, tgts)	×
131	assert fix_result.output == rule_runner.make_snapshot(	×
132	{"good.py": PY_36_GOOD_FILE, "bad.py": PY_36_FIXED_BAD_FILE}
133	)
134	assert fix_result.did_change is True	×
135
136
137	def test_passthrough_args(rule_runner: RuleRunner) -> None:	2✔
138	rule_runner.write_files(	×
139	{"some_file_name.py": PY_38_BAD_FILE, "BUILD": "python_sources(name='t')"}
140	)
141	tgt = rule_runner.get_target(	×
142	Address("", target_name="t", relative_file_path="some_file_name.py")
143	)
144	fix_result = run_pyupgrade(	×
145	rule_runner,
146	[tgt],
147	pyupgrade_arg="--py38-plus",
148	)
149	assert fix_result.output == rule_runner.make_snapshot(	×
150	{"some_file_name.py": PY_38_FIXED_BAD_FILE}
151	)
152	assert fix_result.did_change is True	×

pantsbuild / pants / 18517631058

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous