ianjmacintosh / usdgal / 18510441465

86%

push

github

📱 feat: Offer support as a web app (#215)

* Add PWA manifest

* Add web app manifest

* Add E2E test to confirm web app manifest exists

* Skip flaky test

1) [chromium] › language-handling.spec.ts:95:5 › An en-US user › visiting the /de/ (German) homepage › can dismiss the language alert using a keyboard

    Error: Timed out 5000ms waiting for expect(locator).not.toBeVisible()

    Locator: getByRole('alert')
    Expected: not visible
    Received: visible
    Call log:
      - expect.not.toBeVisible with timeout 5000ms
      - waiting for getByRole('alert')
        9 × locator resolved to <div lang="en" role="alert" aria-hidden="false" class="language-alert" aria-labelledby="language-alert-label">…</div>
          - unexpected value "visible"

      102 |
      103 |       await page.reload();
    > 104 |       await expect(page.getByRole("alert")).not.toBeVisible();
          |                                                 ^
      105 |
      106 |       await page.getByRole("combobox", { name: "Sprache" }).click();
      107 |       await page.getByRole("option", { name: "English" }).click();
        at /home/runner/work/usdgal/usdgal/e2e-tests/language-handling.spec.ts:104:49

* Verify webmanifest is usable

* Explain the manifest test checks validity

146 of 172 branches covered (84.88%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

2799 of 2983 relevant lines covered (93.83%)

41.43 hits per line