ProjectOpenSea / opensea-js / 18507928846

88%

master: 30%

push

github

Clarify JSDoc for orderBy eth_price requirement (addresses #1752) (#1774)

* Clarify JSDoc for orderBy eth_price requirement

Updates documentation for getOrder and getOrders to clarify that when using
orderBy: "eth_price", the asset_contract_address and token_ids parameters
must also be provided, as noted in the API documentation.

Fixes the confusion raised in #1752 without removing the parameters.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Add runtime validation for eth_price orderBy parameter

- Throw descriptive error when orderBy is "eth_price" but required params are missing
- Added validation to both getOrder and getOrders methods
- Error message clearly indicates both asset_contract_address and token_ids are required
- This provides early error detection before API call

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test: remove chain exclusions from getCollections test

- Remove Abstract, ApeChain, Blast, and Zora exclusions
- Keep only Solana excluded (no NFT collections)
- Test now runs for all chains except Solana

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

121 of 415 branches covered (29.16%)

Branch coverage included in aggregate %.

2 of 6 new or added lines in 1 file covered. (33.33%)

645 of 1137 relevant lines covered (56.73%)

2.08 hits per line