stacklok / toolhive / 18493635321

58%

push

github

Remove pointer-to-interface anti-pattern in OAuthFlowResult (#2182)

Changes *oauth2.TokenSource to oauth2.TokenSource throughout the codebase.
Interfaces in Go should not be used as pointers as they are already reference types.

Modified files:
- pkg/auth/discovery/discovery.go: Updated OAuthFlowResult.TokenSource field and assignment
- cmd/thv/app/proxy.go: Updated variable declarations and function signatures
- pkg/runner/remote_auth.go: Updated Authenticate return type
- pkg/runner/runner.go: Updated handleRemoteAuthentication return type
- pkg/transport/http.go: Updated tokenSource field and SetTokenSource method

Fixes #2169

Signed-off-by: kofort9 <kofort9@gmail.com>
Co-authored-by: Muhammad Amir Ejaz <amir@stacklok.com>

0 of 11 new or added lines in 5 files covered. (0.0%)

17574 of 37630 relevant lines covered (46.7%)

15.99 hits per line