ianjmacintosh / usdgal / 18477604243

86%

push

github

🌐 feat: Include lang attribute on page (#213)

* Add generic "home" page with language support

* Set lang attribute on page

The route param is the source of truth; see routes.ts and how home.tsx consumes it via params

* Remove hard-coded language pages

* Quit loading Spanish for English

I have no idea how this bug lasted so long

* Stop testing alert copy

* Always keep state in sync with props

* Listen for wrongLanguage changes via useEffect hook

* Remove the language alert when not needed

* Manage language alert via state

* Confirm language is handled correctly

* Revert "Confirm language is handled correctly"

This reverts commit ad8f2d5a3.

* Confirm the HTML tag has the right lang

* Prerender with languages as params

* Confirm language alert text doesn't change when dismissing

* Render HTML tag with correct lang attribute

* Tell what language the alert uses

* Manage language alert display at parent

* Wait for animation to conclude

The value doesn't actually update until then

* Don't lint React Router's built files

* Don't default to watch mode when testing

* Resolve ESLint warnings

* Share type def with test

146 of 172 branches covered (84.88%)

Branch coverage included in aggregate %.

82 of 135 new or added lines in 9 files covered. (60.74%)

2797 of 2981 relevant lines covered (93.83%)

41.45 hits per line