zhmcclient / python-zhmcclient / test-4058

80%

Build Type

push

github

Committed by andy-maier

Commit Message

Added support for make target 'end2end_check'

Details:

* Added make target 'end2end_check' which runs the existing end2end test
  function test_hmcdef_check_all_hmcs(). This was done by changing the
  'skip' marker on that test function to a new custom marker 'check_hmcs'.

* The test_hmcdef_check_all_hmcs() test function did not yet support the
  recently introduced password commands, because it created its session
  directly. Changed this to call the setup_hmc_session() function instead.

* Improved the test_hmcdef_check_all_hmcs() test function further:
  - Reduced connect timeout/retries in the retry/timeout config.
  - Setup HMC session only once for each HMC definition.
  - Fail the test when there were HMC check errors.

* Because the setup_hmc_session() function used pytest.skip() when the HMC
  is not reachable, this caused the loop through all defined HMCs to end
  prematurely. Fixed this by adding an optional 'skip_on_failure' parameter
  to setup_hmc_session(), that selects between pytest skipping and
  raising exceptions.

* Changed the assertion for correct CPCs in that test function to become
  a print() so that the test function continues through the loop of all defined
  HMCs in that case.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

Run Details

6 of 14 new or added lines in 1 file covered. (42.86%)

1 existing line in 1 file now uncovered.

9248 of 11599 relevant lines covered (79.73%)

9.52 hits per line