tarantool
/
tarantool
/
18379463257
88%
master: 88%
master: 88%
|
Ran
|
Jobs
1
|
Files
513
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.615% (-0.004%) from 87.619%
push
github
sergepetrenkosalad: reserve block before bps_tree_insert_first_elem The commit 51c56d9b3319 ("salad: reserve extents for matras_touch on BPS tree operations") already made the tree self-sufficient - reserved blocks in garbage and extents for `matras_touch` calls prior to insertion and deletion. However, it didn't account for the addition of the first element to the tree, which creates the root leaf - this could also trigger `matras_touch` in `bps_tree_garbage_pop`. However, it turns out there is no need to touch blocks before taking them out of the garbage. There is an invariant that blocks in the garbage are definitely not used by any read views. Although from the point of view of the matras, they require copying and could potentially have been needed by these read views. Let's just remove this `matras_touch` from `bps_tree_garbage_pop`. Also let's reserve a block in the garbage before calling `bps_tree_insert_first_elem` to bring the tree even closer to self-sufficiency. Closes #11788 NO_DOC=bugfix (cherry picked from commit 52b3d4b91)
71268 of 125051 branches covered (56.99%)
5 of 5 new or added lines in 1 file covered. (100.0%)
38 existing lines in 18 files now uncovered.104731 of 119536 relevant lines covered (87.61%)
1380620.97 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 5 |
88.07 |
0.03% | src/box/vy_run.c |
| 4 |
93.05 |
-0.79% | src/box/xrow_update_field.c |
| 4 |
81.82 |
-12.12% | src/lua/minifio.c |
| 3 |
90.5 |
-0.22% | src/box/applier.cc |
| 3 |
91.55 |
-0.58% | src/box/gc.c |
| 3 |
92.54 |
0.04% | src/box/vinyl.c |
| 3 |
84.82 |
-0.21% | src/box/xlog.c |
| 2 |
85.71 |
-9.52% | src/lib/core/tt_sigaction.c |
| 2 |
97.26 |
0.0% | src/lib/msgpuck/msgpuck.h |
| 1 |
95.72 |
-0.12% | src/box/replication.cc |
| 1 |
80.74 |
-0.41% | src/box/tuple_bloom.c |
| 1 |
93.62 |
-0.53% | src/box/vy_range.c |
| 1 |
91.21 |
-0.1% | src/box/vy_scheduler.c |
| 1 |
93.13 |
0.0% | src/lib/core/fiber.c |
| 1 |
65.97 |
-0.46% | src/lib/core/fio.c |
| 1 |
90.38 |
-1.77% | src/lib/core/trigger.cc |
| 1 |
96.15 |
-0.0% | src/lib/salad/bps_tree.h |
| 1 |
22.7 |
-0.02% | src/lib/uri/uri_parser.c |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 18379463257.1 | 513 |
87.61 |
GitHub Action Run |
