safe-global / safe-client-gateway / 18370876006

89%

Build Type

push

github

Committed by web-flow

Commit Message

fix: resolve high-severity memory leaks (#2736)

* fix: resolve high-severity memory leaks and SQL query inefficiencies

This commit addresses 11 high-severity issues identified in the security
and performance analysis:

Memory Leak Fixes:
- Use res.once() instead of res.on() in NotFoundLoggerMiddleware to
  prevent event listener accumulation
- Add proper cleanup for httpUploadProgress listeners in AWS upload streams
- Implement cleanup pattern for stream event listeners (data, error, end)
  in streamToString to prevent orphaned listeners
- Add error handling with .catch() in QueueApiService to prevent unhandled
  promise rejections and memory leaks

SQL Query Optimizations:
- Replace SELECT * with explicit column lists in accounts.datasource.ts
  (getAccount, getDataTypes, upsertAccountDataSettings)
- Replace SELECT * with explicit column lists in counterfactual-safes
  datasource (getCounterfactualSafe, getCounterfactualSafesForAddress)
- Replace SELECT * with explicit column list in address-books datasource
  (getAddressBook)
- Replace SELECT * with explicit column lists in targeted-messaging
  datasource (getUnprocessedOutreaches, createTargetedSafes,
  getTargetedSafe, getSubmission)

Impact:
- Prevents memory leaks from accumulated event listeners in high-traffic
  scenarios
- Reduces database I/O and memory consumption by fetching only required
  columns
- Ensures proper error logging for queue message processing failures
- Improves overall application stability and performance

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* style: run prettier formatting

* test: add missing off method to Upload mock in aws-cloud-storage tests

Fix test failure where upload.off() was called but not mocked in the test suite.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: prevent deadlock in AWS upload stream by returning p... (continued)

Run Details

3858 of 4751 branches covered (81.2%)

Branch coverage included in aggregate %.

18 of 23 new or added lines in 3 files covered. (78.26%)

1 existing line in 1 file now uncovered.

12864 of 14004 relevant lines covered (91.86%)

520.06 hits per line