uber / ringpop-go / 1564

95%

push

travis-ci

Feature: Labels (#167)

* Refractor member selection methods to use a predicate.

This will be useful after labels are landed where a user can add a predicate for labels to be set on a node before it will be taken into account when counting them or looking up their addresses.

* Extend the SWIM protocol with gossiping of user defined labels of a node.

* Refactor swim/mode to only expose reachable members via predicates

* remove swim internal predicate from ringpop.go

* Fixing broken tests

* update mocks

* Do not export the ReachableMember predicate as it is a swim internal.

* Remove unused error

* remove outdated comment

* Use public interface of Node over the more internal function in the memberlist

* specify that predicates need to match for (Get|Count)ReachableMembers.

* return error from Set on Labels when setting the label fails.

* reuse the bytes.Buffer for label checksum calculation.

* Add explanation of predicates to memberlist#GetMembers.

* Only reincarnate when labels are updated.

* Initialize maps for labels with initial size when known

* only reincarnate if we have changed the labels by removing 1

* add extra explanation about predicates to memberlist#CountMembers

* reorder functions in NodeInterface

* Choose highest value of the checksum hash for labels to follow the same paradigm of the rest of the function.

* Rename TestMember to MemberMatchesPredicates

* rename reachableMember to memberIsReachable

* Rename LabeledMember to MemberWithLabelAndValue

* Add READEME.md with cram tests for the role-labels examples

* regenerate code with @generated comment on the first line.

* change labels checksum calculation and document the use of xor for future reference.

* add sleep to prevent flappy test and document that a change to the labels causes the membership to reconverge

* Make changes to local node with the membelist.members lock.

* add error to SetLocalLabels... (continued)

302 of 302 new or added lines in 7 files covered. (100.0%)

4401 of 4630 relevant lines covered (95.05%)

4.2 hits per line