tarantool / tarantool / 18306858566

88%

Build Type

push

github

Committed by sergepetrenko

Commit Message

salad: reserve block before bps_tree_insert_first_elem

The commit 51c56d9b3319 ("salad: reserve extents for matras_touch on BPS
tree operations") already made the tree self-sufficient - reserved
blocks in garbage and extents for `matras_touch` calls prior to insertion
and deletion. However, it didn't account for the addition of the first
element to the tree, which creates the root leaf - this could also trigger
`matras_touch` in `bps_tree_garbage_pop`.

However, it turns out there is no need to touch blocks before taking them
out of the garbage. There is an invariant that blocks in the garbage are
definitely not used by any read views. Although from the point of view of
the matras, they require copying and could potentially have been needed by
these read views. Let's just remove this `matras_touch` from
`bps_tree_garbage_pop`. Also let's reserve a block in the garbage before
calling `bps_tree_insert_first_elem` to bring the tree even closer to
self-sufficiency.

Closes #11788

NO_DOC=bugfix

Run Details

71277 of 125129 branches covered (56.96%)

5 of 5 new or added lines in 1 file covered. (100.0%)

51 existing lines in 15 files now uncovered.

104806 of 119614 relevant lines covered (87.62%)

1357666.05 hits per line