optimizely / agent / 18291298483

86%

master: 87%

Build Type

Pull #444

github

Committed by Mat001

Commit Message

Complete fix for goroutine lifecycle race condition in Subscribe

Address comprehensive goroutine lifecycle management issue:

Problem:
The previous fix with buffered channel only prevented blocking, but didn't
prevent goroutine leaks. When the main function returns with an error or
due to context cancellation BEFORE the goroutine enters its main loop, the
goroutine would continue running indefinitely until the original context
expires (could be much later).

Complete Solution:
1. Added stop channel (chan struct{}) to signal goroutine termination
2. Goroutine checks stop channel during initialization (both error and success paths)
3. Goroutine checks stop channel as first case in main select loop
4. Main function closes stop channel when returning with error or ctx.Done()
5. Main function does NOT close stop on success - goroutine continues normally

This ensures:
- No goroutine leaks when Subscribe returns early with error
- No goroutine leaks when context is cancelled during initialization
- Clean resource cleanup via defer statements
- Goroutine runs normally when initialization succeeds

Verified with race detector running 3 consecutive times.

Pull Request Pull Request #444: [FSSDK-] Add redis-streams

Run Details

440 of 521 new or added lines in 6 files covered. (84.45%)

3 existing lines in 1 file now uncovered.

3316 of 3842 relevant lines covered (86.31%)

2491.66 hits per line