optimizely / agent / 18291136855

86%

master: 87%

Build Type

Pull #444

github

Committed by Mat001

Commit Message

Fix race condition in Subscribe ready channel

Address reviewer feedback on race condition that was only partially fixed:

Problem:
- If context is cancelled while goroutine is initializing, the main
  function returns via ctx.Done() case but goroutine continues running
- Goroutine could block trying to send to ready channel if no receiver
- This creates a goroutine leak

Solution:
- Wrap both ready channel sends in select statements
- Check ctx.Done() before sending to ready channel
- If main function already returned, goroutine exits immediately
- Prevents goroutine from blocking on channel send

This ensures proper cleanup when Subscribe() caller cancels the context
during the initialization phase.

Pull Request Pull Request #444: [FSSDK-] Add redis-streams

Run Details

438 of 514 new or added lines in 6 files covered. (85.21%)

3 existing lines in 1 file now uncovered.

3314 of 3835 relevant lines covered (86.41%)

3425.08 hits per line