tari-project / tari / 18279939245

62%

Build Type

push

github

Committed by web-flow

Commit Message

feat: track ConsensusConstants to detect network changes and notify user (#7533)

## Problem

The minotari_node currently has no mechanism to detect when
ConsensusConstants have changed between restarts. This creates a risk
where a node operator might unknowingly run an incompatible version
after consensus rule changes have already taken effect, potentially
leading to network fork issues or sync problems.

## Solution

This PR implements a lightweight ConsensusConstants tracking system
that:

1. **Stores consensus constants** on each startup in
`{data_dir}/consensus_constants.json`
2. **Compares constants** between restarts to detect changes
3. **Validates timing** - only raises errors when new constants are
already active at current blockchain height
4. **Provides clear feedback** to users about potential network
compatibility issues

## Implementation Details

### New Components

- **ConsensusConstantsTracker**: A new module that handles persistence
and comparison of consensus constants
- **Integration point**: Added to node startup flow in `builder.rs`
after database initialization but before node start
- **Minimal storage**: Only tracks essential fields needed for
compatibility detection

### User Experience

The implementation provides different behaviors based on the situation:

- **First startup**: Silent operation, creates tracking file
- **No changes**: Silent operation, continues normally  
- **Constants changed, not yet active**: Info log message, continues
normally
- **Constants changed, already active**: **Critical error with clear
message and exit**

Example error message:
```
CRITICAL: Consensus constants have changed and the new constants are already active!
Current height: 15000
Active consensus constants changed from effective height 0 to 15000  
This indicates a potential network fork or version mismatch.
Please verify you are running the correct version of the node for this network.
```

### Files Changed

- `base_layer/core/src/ch... (continued)

Run Details

67 of 70 new or added lines in 7 files covered. (95.71%)

1118 existing lines in 28 files now uncovered.

66535 of 113537 relevant lines covered (58.6%)

550271.13 hits per line