go-playground / validator / 18261600532

74%

v8: 100%

push

github

Fixed missing keys from returned errors in map validation (#1284)

## Fixes Or Enhances

### Bug Description:
The `ValidateMapCtx` function calls the `VarCtx(ctx context.Context,
field interface{}, tag string) (err error)` method, but the returned
errors do not contain keys.
```go
package main

import (
	"fmt"

	"github.com/go-playground/validator/v10"
)

func main() {
	validate := validator.New()

	data := map[string]interface{}{"email": "emailaddress"}
	rules := map[string]interface{}{"email": "required,email"}
	errs := validate.ValidateMap(data, rules) // when VarCtx is called
	fmt.Println(errs)
	//output: map[email:Key: '' Error:Field validation for '' failed on the 'email' tag]
}

```
### Fix:
Added a new method `VarWithKeyCtx(ctx context.Context, key string, field
interface{}, tag string) (err error)` to support validating a single
variable, ensuring that the returned error contains the key of the
field. This retains compatibility with the current `VarCtx(...)` method.
Now, `ValidateMapCtx` will call the new `VarWithKeyCtx(...)` method.
```go
package main

import (
	"fmt"

	"github.com/go-playground/validator/v10"
)

func main() {
	validate := validator.New()

	data := map[string]interface{}{"email": "emailaddress"}
	rules := map[string]interface{}{"email": "required,email"}
	errs := validate.ValidateMap(data, rules) // when the new VarWithKeyCtx is called
	fmt.Println(errs)
	//output: map[email:Key: 'email' Error:Field validation for 'email' failed on the 'email' tag]
}

```

**Make sure that you've checked the boxes below before you submit PR:**
- [x] Tests exist or have been written that cover this particular
change.

@go-playground/validator-maintainers

26 of 28 new or added lines in 1 file covered. (92.86%)

14355 of 19475 relevant lines covered (73.71%)

78.16 hits per line