997
66%

Ran 10 May 2014 06:21PM UTC

Jobs 10

Files 303

Run time 5min

Badge

Embed ▾

pending completion

Build # 997

Build Type

push

travis-ci

Committed by

bdarnell

Commit Message

Improve performance by using Future interface when writing HTTP responses.

Previously, we passed a callback to IOStream.write() and also checked
IOStream.writing() to see if the write completed synchronously (which is
the common case).  If it did, we would complete the request immediately
but the write callback would remain on the IOLoop until its next iteration,
keeping the request state from being garbage collected.

In benchmarks, this would manifest as as something like a memory leak,
since benchmarks often handle many requests in one IOLoop iteration.
This slowed things down (by about 10% in my benchmarks) by increasing
pressure on the garbage collector.

Run Details

54136 of 71581 relevant lines covered (75.63%)

1.33 hits per line

Uncovered Existing Lines

Lines	Coverage	File
8	100.0	/home/travis/virtualenv/python3.3.5/lib/python3.3/site-packages/tornado-3.3.dev1-py3.3-linux-x86_64.egg/tornado/http1connection.py
8	100.0	/home/travis/virtualenv/python3.2.5/lib/python3.2/site-packages/tornado-3.3.dev1-py3.2-linux-x86_64.egg/tornado/http1connection.py
8	100.0	/home/travis/virtualenv/pypy-2.2.1/site-packages/tornado-3.3.dev1-py2.7.egg/tornado/http1connection.py
8	100.0	/home/travis/virtualenv/python2.7.6/lib/python2.7/site-packages/tornado-3.3.dev1-py2.7-linux-x86_64.egg/tornado/http1connection.py

Jobs

ID	Job ID	Ran	Coverage
1	997.1 (DEPS=true)	10 May 2014 06:23PM UTC		Travis Job 997.1
2	997.2 (DEPS=false)	10 May 2014 06:21PM UTC		Travis Job 997.2
3	997.3 (DEPS=true)	10 May 2014 06:24PM UTC		Travis Job 997.3
4	997.4 (DEPS=false)	10 May 2014 06:21PM UTC	80.78	Travis Job 997.4
5	997.5 (DEPS=true)	10 May 2014 06:26PM UTC	62.83	Travis Job 997.5
6	997.6 (DEPS=false)	10 May 2014 06:26PM UTC	63.02	Travis Job 997.6
7	997.7 (DEPS=true)	10 May 2014 06:22PM UTC	81.58	Travis Job 997.7
8	997.8 (DEPS=false)	10 May 2014 06:22PM UTC	81.62	Travis Job 997.8
9	997.9 (DEPS=true)	10 May 2014 06:23PM UTC	86.65	Travis Job 997.9
10	997.10 (DEPS=false)	10 May 2014 06:23PM UTC	86.74	Travis Job 997.10

Source Files on build 997

Detailed source file information is not available for this build.

facebook / tornado / 997
66%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 997

facebook / tornado / 997 66%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 997

facebook / tornado / 997
66%

README BADGES
x