TAKETODAY / today-infrastructure / 18239483914

85%

push

github

:fire: Remove unused SHA-1 hash from UNPACK markers

In InfraZipCopyAction and AbstractJarWriter, SHA-1 hash is calculated for
stored entries requiring unpack and set as entry comment. However, the
hash isn't used anywhere, just the marker prefix 'UNPACK:' is checked.

This commit removes the unnecessary SHA-1 hash calculation which reads
the file completely in memory, potentially three times in extreme cases.
Now the comment is simply set to 'UNPACK:' without any hash, improving
performance.

59818 of 78041 branches covered (76.65%)

Branch coverage included in aggregate %.

141260 of 167516 relevant lines covered (84.33%)

3.6 hits per line