• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

optimizely / agent / 18231809236
86%
master: 87%

Build:
Build:
LAST BUILD BRANCH: refs/tags/v4.4.0
DEFAULT BRANCH: master
Ran 03 Oct 2025 07:27PM UTC
Jobs 1
Files 51
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

03 Oct 2025 07:18PM UTC coverage: 84.791% (-1.4%) from 86.177%
18231809236

Pull #444

github

Mat001
Fix race condition in Redis Streams Subscribe and test timeouts

This commit addresses two critical issues found during integration testing:

1. Race condition in Subscribe() method:
   - Subscribe() was returning immediately while consumer group creation
     happened asynchronously in a goroutine
   - This caused NOGROUP errors when messages were published before the
     consumer group was fully initialized
   - Fixed by adding a synchronization channel (ready) that waits for
     consumer group creation to complete before returning

2. Consumer group creation using wrong client:
   - createConsumerGroupWithRetry() was ignoring the passed client parameter
   - It created temporary clients via executeWithRetry() which were immediately closed
   - Fixed to use the persistent client from Subscribe() goroutine

3. Test timeout adjustments:
   - Both Subscribe tests now wait 6 seconds (longer than 5s flush interval)
   - Previously they waited exactly at or below flush interval causing flakiness
   - Tests now pass reliably 10/10 runs

All Redis Streams tests now pass consistently.
Pull Request #444: [FSSDK-] Add redis-streams

371 of 492 new or added lines in 5 files covered. (75.41%)

2 existing lines in 1 file now uncovered.

3239 of 3820 relevant lines covered (84.79%)

3114.49 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
12
87.16
-7.07% pkg/syncer/pubsub.go
20
46.05
-16.45% plugins/odpcache/services/redis_cache.go
20
57.14
-20.05% plugins/userprofileservice/services/redis_ups.go
69
81.55
pkg/syncer/pubsub/redis_streams.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
87.16
-7.07% pkg/syncer/pubsub.go
Jobs
ID Job ID Ran Files Coverage
1 18231809236.1 03 Oct 2025 07:27PM UTC 51
84.79
GitHub Action Run
Source Files on build 18231809236
  • Tree
  • List 51
  • Changed 3
  • Source Changed 0
  • Coverage Changed 3
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #444
  • PR Base - master (#17843218393)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc