optimizely / agent / 18231809236

86%

master: 87%

Build Type

Pull #444

github

Committed by Mat001

Commit Message

Fix race condition in Redis Streams Subscribe and test timeouts

This commit addresses two critical issues found during integration testing:

1. Race condition in Subscribe() method:
   - Subscribe() was returning immediately while consumer group creation
     happened asynchronously in a goroutine
   - This caused NOGROUP errors when messages were published before the
     consumer group was fully initialized
   - Fixed by adding a synchronization channel (ready) that waits for
     consumer group creation to complete before returning

2. Consumer group creation using wrong client:
   - createConsumerGroupWithRetry() was ignoring the passed client parameter
   - It created temporary clients via executeWithRetry() which were immediately closed
   - Fixed to use the persistent client from Subscribe() goroutine

3. Test timeout adjustments:
   - Both Subscribe tests now wait 6 seconds (longer than 5s flush interval)
   - Previously they waited exactly at or below flush interval causing flakiness
   - Tests now pass reliably 10/10 runs

All Redis Streams tests now pass consistently.

Pull Request Pull Request #444: [FSSDK-] Add redis-streams

Run Details

371 of 492 new or added lines in 5 files covered. (75.41%)

2 existing lines in 1 file now uncovered.

3239 of 3820 relevant lines covered (84.79%)

3114.49 hits per line