stacklok / toolhive / 18197180827

71%

Build Type

push

github

Committed by web-flow

Commit Message

Fix authz behavior on `tools/list` (#2061)

This is a follow up of #1189 specifically targeted to SSE streams from
different request, i.e. handling of the SSE transport.

This doesn't modify or add any code under `pkg/authz`, but does add a
test pinning the current behavior.

In order to write the test more easily, I added clients to
`pkg/testkit` so that when a specific test server is initialized, a
pre-configured client exposing `ToolsList()` and `ToolsCall()`
routines is returned along.

The returned client masks any transport specific behavior so that
developers writing new tests don't have to bother anymore handling SSE
streams, goroutines, or channel closure anymore.

Fixes #1188

Coverage Stats

151 of 216 new or added lines in 3 files covered. (69.91%)

23 existing lines in 2 files now uncovered.

16553 of 36301 relevant lines covered (45.6%)

15.49 hits per line