bitcoindevkit / bdk / 18184758536

79%

push

github

Merge bitcoindevkit/bdk#2052: chain: replace `ScriptBuf` with `&Script` in SPK index methods

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/c095145864a97b5efb4c90ef81989185b5a06998">c09514586 refactor(chain): replace `ScriptBuf` with `AsRef<Script>` in SPK index methods (Yuki Kishimoto)

Pull request description:

  ### Description

  Replace `ScriptBuf` with `&Script` in `SpkTxOutIndex::index_of_spk` and `KeychainTxOutIndex::index_of_spk` methods, to avoid the need of cloning the `ScriptBuf` for a SPK index lookup.

  ### Changelog notice

  Breaking changes:
  - Change `SpkTxOutIndex::index_of_spk` and `KeychainTxOutIndex::index_of_spk` args from `ScriptBuf` to `&Script`.

  ### Checklists

  #### All Submissions:

  * [X] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [X] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  oleonardolima:
    cACK c095145864a97b5efb4c90ef81989185b5a06998
  evanlinjin:
    ACK c095145864a97b5efb4c90ef81989185b5a06998

Tree-SHA512: f77bb4d9b76181d085893673aa17f99f085

378 of 512 branches covered (73.83%)

Branch coverage included in aggregate %.

5 of 8 new or added lines in 2 files covered. (62.5%)

4205 of 5316 relevant lines covered (79.1%)

2991.45 hits per line