Qiskit / qiskit / 18104357474
88%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 868
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 88.301% (-0.006%) from 88.307%
18104357474

push

github

web-flow 
Bump Rust edition to edition 2024 (#14876)

* Bump Rust edition to edition 2024

Now that our MSRV is set to be 1.85 this enables us to use the new rust
edition 2024. While there are some behavior changes especially around
temporaries, drop order, etc there are also some nice QoL improvements
to using the new edition. This commit opts in to using the new edition,
runs cargo fix on the repository to auto update a lot of the code,
fixes the compilation errors after this, and then cleans up the code.
The details on what changes in rust edition 2024 can be found here:

https://doc.rust-lang.org/nightly/edition-guide/rust-2024/index.html

For right now the cargo fmt rules are left on edition 2021 to minimize
the diff size here. We will do that change in a follow up PR as it will
be a larger diff that we likely want to add to the git blame exclude
list.

* Fix clippy issue

* Undo conversions of `if let`

`cargo fix --edition` converts all `if let` into corresponding `match`
statements, because the drop order changed slightly.  We do not rely on
the old drop order in any cases, so in general we can remove all those
changes.  This commit leaves a couple in place where the `match`
statement resulted in neater code.

* Avoid wildcard `match` statements

* Fix clippy complaints

* Run formatter

---------

Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

70 of 89 new or added lines in 18 files covered. (78.65%)

18 existing lines in 4 files now uncovered.

92857 of 105160 relevant lines covered (88.3%)

1168674.65 hits per line

Uncovered Changes

Lines Coverage ∆ File
5
92.86
0.1% crates/quantum_info/src/convert_2q_block_matrix.rs
3
74.23
0.08% crates/qasm3/src/exporter.rs
3
52.31
2.31% crates/transpiler/src/passes/sabre/heuristic.rs
2
88.89
-1.68% crates/cext/src/transpiler/passes/commutative_cancellation.rs
2
78.26
-3.56% crates/cext/src/transpiler/passes/remove_identity_equiv.rs
2
59.52
-0.72% crates/cext/src/transpiler/transpile_function.rs
1
82.56
0.0% crates/synthesis/src/discrete_basis/math.rs
1
54.79
0.0% crates/transpiler/src/angle_bound_registry.rs

Coverage Regressions

Lines Coverage ∆ File
9
72.82
-0.29% crates/circuit/src/parameter/symbol_expr.rs
7
91.49
-0.77% crates/qasm2/src/lex.rs
1
74.23
0.08% crates/qasm3/src/exporter.rs
1
96.28
-0.32% crates/transpiler/src/passes/gate_direction.rs
Jobs
ID Job ID Ran Files Coverage
1 18104357474.1 868
88.3
GitHub Action Run
Source Files on build 18104357474