bitcoindevkit / bdk / 18083167753
79%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 28
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.657% (-0.7%) from 79.35%
18083167753

push

github

oleonardolima 
Merge bitcoindevkit/bdk#2029: `CanonicalView`

1311a2ed0 refactor(chain)!: Change trust_predicate to accept FullTxOut (志宇)
3f9eec54e refactor(example): Reuse `CanonicalView` in filter iter example (志宇)
40790d006 docs(chain): Tighten `CanonicalView` documentation (志宇)
f444a8de3 refactor(chain)!: Rename `CanonicalViewTx` to `CanonicalTx` (志宇)
8ad138d02 docs(chain): Improve CanonicalView documentation (志宇)
beb16a146 feat(chain)!: Remove `CanonicalTx` (志宇)
54409bc4a test(chain): Add comprehensive tests for min_confirmations parameter (志宇)
45249457a feat(chain): Add min_confirmations parameter to CanonicalView::balance (志宇)
0a55710ea feat(chain)!: Introduce `CanonicalView` and migrate API (志宇)

Pull request description:

  ### Description

  `CanonicalView` allows us to canonicalize upfront, reducing our API surface and improving performance by reducing canonicalizations we need to do.

  This is also the first step to achieving many of our goals.

  * Event notifications.
  * Intent tracker.
  * Getting rid of `CanonicalUnspents` structure in `bdk_tx`.

  ### Changelog notice

  ```md
  Added
  - Introduce `CanonicalView` which allows us to canonicalize once upfront.
  - Added `TxGraph::canonical_view` which constructs a `CanonicalView`.

  Changed
  - `TxGraph` methods which require canonicalization now have `CanonicalView` equivalents.

  Removed
  - `TxGraph` methods which take in a fallible `ChainOracle` implementations are now removed.

  ```

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I'v... (continued)

378 of 512 branches covered (73.83%)

Branch coverage included in aggregate %.

212 of 241 new or added lines in 3 files covered. (87.97%)

26 existing lines in 3 files now uncovered.

4203 of 5312 relevant lines covered (79.12%)

3118.56 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
3
81.7
 -3.89% crates/chain/src/tx_graph.rs
4
69.02
 -3.61% crates/chain/src/indexed_tx_graph.rs
22
90.38
 crates/chain/src/canonical_view.rs

Uncovered Existing Lines

Lines Coverage ∆ File
4
69.02
 -3.61% crates/chain/src/indexed_tx_graph.rs
6
94.12
 -3.92% crates/core/src/checkpoint.rs
16
81.7
 -3.89% crates/chain/src/tx_graph.rs
Jobs
ID Job ID Ran Files Coverage
1 18083167753.1 28
78.66
 GitHub Action Run
Source Files on build 18083167753