django-import-export / django-import-export / 18074717997

100%

push

github

Call `get_export_fields()` (not `get_import_fields()`) to populate admin UI export form (#2118)

* Fix export forms showing import fields instead of export fields (issue #2094)

This commit addresses issue #2094 where export forms in the admin interface
were incorrectly displaying import fields instead of export fields.

## Changes Made

### Core Fix
- Added `get_user_visible_import_fields()` method to return fields for import interface
- Added `get_user_visible_export_fields()` method to return fields for export interface
- Updated admin.py to use context-specific methods:
  - Import contexts now use `get_user_visible_import_fields()`
  - Export contexts now use `get_user_visible_export_fields()`

### Deprecation
- Deprecated `get_user_visible_fields()` in v4.4 for removal in v6.0
- Added clear deprecation warning with migration guidance
- Method now issues DeprecationWarning directing users to new methods

### Tests
- Added comprehensive tests for import/export field display in admin forms
- Added test coverage for deprecation warning
- All existing tests continue to pass

## Breaking Changes
None - this is fully backward compatible. The deprecated method continues
to work with a warning until v6.0.

## Migration Path
Replace calls to:
- `get_user_visible_fields()` in import contexts with `get_user_visible_import_fields()`
- `get_user_visible_fields()` in export contexts with `get_user_visible_export_fields()`

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* tidied comments

* Fix SelectableFieldsExportForm to respect overridden get_export_fields()

SelectableFieldsExportForm was using get_export_order() instead of
get_export_fields(), causing it to show all fields rather than only
the fields returned by an overridden get_export_fields() method.

Changes:
- Modified _create_boolean_fields() to detect when get_export_fields()
  is overridden and use it instead of get_export_order()
- Maintains... (continued)

19 of 19 new or added lines in 2 files covered. (100.0%)

2322 of 2322 relevant lines covered (100.0%)

4.98 hits per line