tari-project / tari / 18039653182
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 705
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.88% (-0.08%) from 60.957%
18039653182

push

github

web-flow 
fix: update ledger wallet sdk to newer ledger firmware (#7520)

Description
---
- Updated ledger wallet to use the latest ledger_device_sdk.
- Also updated the ledger wallet rust toolchain.
- Fixed double `comm.reply_ok();` sent from the ledger device - this
caused the the accessor methods to receive an empty data array, the
first containing the data and the second containing the empty array.

Motivation and Context
---
See above.

How Has This Been Tested?
---
- System-level testing passed (send & recieve).
- Demo passed:
```
cargo run --release --example ledger_demo
    Finished `release` profile [optimized] target(s) in 1.11s
     Running `target\release\examples\ledger_demo.exe`

Transport created in 26.7992ms
Transport created in 11.8355ms
Transport created in 14.8429ms
Transport created in 11.8416ms
Transport created in 12.8842ms
Transport created in 11.903ms
Transport created in 13.8822ms
Transport created in 11.9641ms
Transport created in 14.883ms
Transport created in 11.8267ms

Result data: [1, 98, 229, 50, 140, 22, 238, 33, 222, 42, 25, 252, 173, 215, 208, 105, 100, 217, 79, 187, 33, 141, 151, 212, 144, 248, 237, 197, 107, 68, 34, 39, 121]
Application verified in 1.6788405s
Application verified in 200ns
Application verified in 100ns
Application verified in 100ns
Application verified in 100ns
Application verified in 100ns
Application verified in 100ns
Application verified in 100ns
Application verified in 100ns
Application verified in 100ns


test: GetAppName
app name:       minotari_ledger_wallet

test: GetVersion
version:        5.1.0-pre.2

test: GetPublicAlpha
public_alpha:   d4edcf00d86e4d62823e900a906bab46a

test: GetPublicKey
Result data: [1, 90, 154, 86, 152, 203, 121, 156, 164, 81, 186, 107, 138, 195, 132, 157, 244, 235, 38, 183, 72, 223, 220, 1, 29, 94, 184, 211, 220, 75, 84, 53, 59]
public_key:     5a9a5698cdfdc011d5eb8d3dc4b54353b
Result data: [1, 88, 73, 90, 146, 76, 10... (continued)

0 of 5 new or added lines in 1 file covered. (0.0%)

2180 existing lines in 29 files now uncovered.

74589 of 122519 relevant lines covered (60.88%)

222551.71 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
5
0.0
 0.0% applications/minotari_ledger_wallet/comms/src/accessor_methods.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
99.44
 0.02% base_layer/core/src/test_helpers/mod.rs
1
75.98
 -0.22% comms/core/src/connection_manager/peer_connection.rs
1
56.14
 0.32% comms/core/src/connectivity/manager.rs
2
65.09
 1.02% base_layer/core/src/blocks/accumulated_data.rs
6
0.0
 0.0% base_layer/wallet/src/output_manager_service/recovery/standard_outputs_recoverer.rs
7
95.07
 0.02% base_layer/transaction_components/src/coinbase_builder.rs
7
87.86
 -0.91% base_layer/transaction_components/src/offline_signing/offline_signer.rs
8
50.0
 -50.0% base_layer/transaction_key_manager/src/schema.rs
11
0.0
 0.0% base_layer/transaction_components/src/key_manager/error.rs
15
59.76
 0.0% comms/core/src/builder/mod.rs
17
51.16
 -24.59% base_layer/transaction_components/src/key_manager/memory_key_manager.rs
18
0.0
 0.0% base_layer/transaction_components/src/transaction_components/unblinded_output.rs
19
36.84
 -16.67% base_layer/transaction_key_manager/src/storage/sqlite_db/key_manager_state.rs
21
0.0
 0.0% base_layer/transaction_components/src/key_manager/initializer.rs
21
91.38
 -0.03% base_layer/transaction_components/src/offline_signing/one_sided_signer.rs
31
0.0
 0.0% base_layer/transaction_components/src/multisig/session.rs
37
92.63
 0.16% base_layer/transaction_components/src/consensus/consensus_constants.rs
42
75.25
 11.89% base_layer/transaction_components/src/key_manager/interface.rs
42
94.88
 0.0% base_layer/transaction_components/src/transaction_builder/builder.rs
48
11.84
 -1.02% base_layer/transaction_components/src/offline_signing/models.rs
64
0.0
 -80.0% base_layer/transaction_key_manager/src/storage/sqlite_db/imported_keys.rs
67
27.43
 -28.27% base_layer/transaction_key_manager/src/storage/sqlite_db/mod.rs
84
71.04
 1.32% base_layer/transaction_components/src/key_manager/wrapper.rs
87
50.54
 0.16% base_layer/transaction_components/src/transaction_components/wallet_output.rs
105
0.0
 0.0% applications/minotari_utils/src/commands/dbstats.rs
282
0.0
 0.0% base_layer/wallet/src/output_manager_service/service.rs
316
56.44
 0.08% base_layer/core/src/chain_storage/blockchain_database.rs
369
57.84
 0.92% base_layer/transaction_components/src/key_manager/inner.rs
451
0.0
 0.0% base_layer/wallet/src/transaction_service/service.rs
Jobs
ID Job ID Ran Files Coverage
1 18039653182.1 705
60.88
 GitHub Action Run
Source Files on build 18039653182