18040807458
58%

Ran 26 Sep 2025 02:35PM UTC

Jobs 1

Files 139

Run time 1min

Badge

Embed ▾

Committed 26 Sep 2025 02:33PM UTC coverage: 44.264% (-1.3%) from 45.597%

Build # 18040807458

Build Type

push

github

Committed by

web-flow

Commit Message

fix(conversation): Use dedicated title generation model configuration (#262)

The title generator task was ignoring the
`conversation.title.generate.model` configuration and always using the
assistant model instead. This prevented users from specifying a
different model optimized for title generation.

Now the title generator properly checks for a dedicated title model
configuration first, falling back to the assistant model only when no
dedicated model is configured. Additionally, title generation now uses
optimized reasoning parameters (low effort, excluded from output) unless
explicitly overridden.

This change also refactors reasoning parameter access across LLM
providers to use direct field access instead of getter methods, and adds
convenient `From` trait implementations for reasoning configuration
types.

Signed-off-by: Jean Mertz <git@jeanmertz.com>

Run Details

17 of 47 new or added lines in 8 files covered. (36.17%)

902 existing lines in 38 files now uncovered.

6158 of 13912 relevant lines covered (44.26%)

5.65 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	63.07	-0.25%	crates/jp_llm/src/provider/ollama.rs
3	51.61	-14.72%	crates/jp_config/src/model/parameters.rs
4	31.69	0.0%	crates/jp_cli/src/cmd/query.rs
22	0.0	0.0%	crates/jp_task/src/task/title_generator.rs

Uncovered Existing Lines

Lines	Coverage	∆	File
1	0.0	0.0%	crates/jp_attachment_mcp_resources/src/lib.rs
4	0.0	0.0%	crates/jp_cli/src/cmd/attachment/rm.rs
7	63.43	0.0%	crates/jp_attachment_bear_note/src/lib.rs
7	58.82	-24.51%	crates/jp_config/src/conversation/title.rs
7	61.11	-30.56%	crates/jp_config/src/providers/llm/deepseek.rs
7	61.11	-30.56%	crates/jp_config/src/providers/llm/llamacpp.rs
7	61.11	-30.56%	crates/jp_config/src/providers/llm/ollama.rs
8	88.03	-1.49%	crates/jp_attachment_cmd_output/src/lib.rs
8	62.5	-23.21%	crates/jp_config/src/conversation.rs
8	60.0	-25.71%	crates/jp_config/src/conversation/title/generate.rs
8	61.9	-30.95%	crates/jp_config/src/providers/llm/google.rs
8	55.56	-27.78%	crates/jp_config/src/style/reasoning.rs
8	55.56	-27.78%	crates/jp_config/src/style/tool_call.rs
9	91.26	-5.65%	crates/jp_config/src/model.rs
9	62.5	-31.25%	crates/jp_config/src/providers/llm/anthropic.rs
9	62.5	-31.25%	crates/jp_config/src/providers/llm/openai.rs
9	65.38	-29.06%	crates/jp_config/src/style.rs
10	62.96	-31.48%	crates/jp_config/src/providers/llm/openrouter.rs
11	63.33	-31.67%	crates/jp_config/src/style/code.rs
11	66.67	-9.52%	crates/jp_config/src/template.rs
12	63.64	-17.13%	crates/jp_config/src/conversation/tool/style.rs
12	66.67	-16.09%	crates/jp_config/src/style/typewriter.rs
13	45.71	-13.54%	crates/jp_config/src/providers.rs
15	89.36	-9.85%	crates/jp_config/src/assistant.rs
16	74.76	-5.45%	crates/jp_config/src/editor.rs
18	68.42	-15.45%	crates/jp_config/src/providers/llm.rs
22	26.32	0.0%	crates/jp_attachment/src/lib.rs
22	85.71	-10.64%	crates/jp_config/src/lib.rs
22	67.07	-6.26%	crates/jp_config/src/model/id.rs
26	74.34	-0.32%	crates/jp_attachment_file_content/src/lib.rs
27	0.0	0.0%	crates/jp_cli/src/ctx.rs
36	14.04	-7.59%	crates/jp_config/src/providers/mcp.rs
38	73.46	-11.54%	crates/jp_config/src/assistant/instructions.rs
48	51.61	-14.72%	crates/jp_config/src/model/parameters.rs
58	32.96	4.77%	crates/jp_conversation/src/message.rs
63	0.0	0.0%	crates/jp_cli/src/lib.rs
100	31.69	0.0%	crates/jp_cli/src/cmd/query.rs
198	40.33	-7.33%	crates/jp_config/src/conversation/tool.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	18040807458.1	26 Sep 2025 02:35PM UTC	139	44.26	GitHub Action Run

dcdpr / jp / 18040807458
58%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 18040807458

dcdpr / jp / 18040807458 58%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 18040807458

dcdpr / jp / 18040807458
58%

README BADGES
x