Neptune-Crypto / neptune-core / 18009448670

75%

Build Type

push

github

Committed by Sword-Smith

Commit Message

perf(archival_mutator_set): use batch-removal method to update archival mutator set

Instead of looping over all removal records, and keeping each one up to
date, while applying each removal record individually, we use the (newly
fixed) `ArchivalMutatorSet::batch_remove` which doesn't bother with
updating the MMR authentication paths of each applied removal record but
rather just looks at the chunks and applies all removal records while
keeping the rest of the data structure consistent.

Huge speed increase! 2.9x overall in our most central state-related
method `GlobalState::set_new_tip` (when applying two blocks, first with
1 input, 1000 outputs; second with 1000 inputs, 2000 outputs). So the
speed increase of this individual step in archival mutator set is likely
much more than the overall 2.9x speedup, since the new benchmark only
measures the total time spent in `set_new_tip`.

Prior to this commit:
set_new_tip                        fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ set_new_tip                                   │               │               │               │         │
   ╰─ set_new_tip                  9.681 s       │ 10.82 s       │ 10.58 s       │ 10.45 s       │ 10      │ 10

Now:
set_new_tip                        fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ set_new_tip                                   │               │               │               │         │
   ╰─ set_new_tip                  2.734 s       │ 3.939 s       │ 3.698 s       │ 3.577 s       │ 10      │ 10

This closes #684.

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

517 existing lines in 16 files now uncovered.

24858 of 33769 relevant lines covered (73.61%)

662755.78 hits per line