tari-project / tari / 18003082473

62%

Build Type

push

github

Committed by web-flow

Commit Message

chore: revert accumulated difficulty fix and let orphans clean at startup (#7513)

Description
---
- Revert "fix: accumulated data in c29 (#7507)" This reverts commit
840c6d24e.
- Revert "fix: remove ban for wrong accumulated difficulty" This reverts
commit ccb41e6c5.
- Set `cleanup_orphans_at_startup` config option to true to combat the
base node being fixated on bad orphan blocks - this stops the node from
syncing when it happens.

Motivation and Context
---
Network forks and base nodes cannot sync anymore

How Has This Been Tested?
---
System-level testing.

What process can a PR reviewer use to test or verify this change?
---

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [ ] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [x] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
BREAKING CHANGE: This changes back the accumulated difficulty
calculation to that which is currently the official release.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- Refactor
- Updated accumulated difficulty calculation; reported totals may
change.
- Chores
  - Base node now cleans up orphan blocks on startup by default.
- Tightened peer ban policy: inaccurate chain metadata now triggers a
short ban.
- Documentation
- Config preset comments updated to reflect the new orphan-cleanup
default.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Run Details

2 of 4 new or added lines in 3 files covered. (50.0%)

64 existing lines in 9 files now uncovered.

74565 of 122299 relevant lines covered (60.97%)

222853.45 hits per line