stacklok / toolhive / 17941639158

59%

Build Type

push

github

Committed by web-flow

Commit Message

Fix flaky TestGetRegistryAPIImage test by using dependency injection (#2002)

The test was flaky because it manipulated global environment variables
while running in parallel, causing race conditions between test cases.

This change refactors the getRegistryAPIImage function to accept an
environment getter function parameter, allowing tests to use isolated
mock functions instead of manipulating global state.

Changes:
- Add getRegistryAPIImageWithEnvGetter function for dependency injection
- Update test to use mock environment getter instead of os.Setenv/Unsetenv
- Remove unused os import from test file
- Maintain backward compatibility with existing getRegistryAPIImage function

The test now runs reliably in parallel without race conditions.

Run Details

4 of 4 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

15700 of 35127 relevant lines covered (44.69%)

15.65 hits per line