bitcoindevkit / bdk_wallet / 17880251240

85%

push

github

Merge bitcoindevkit/bdk_wallet#302: refactor: have a structured IndexOutOfBoundsError type

<a class=hub.com/bitcoindevkit/bdk_wallet/commit/42d9b907a18074e53154cea5e2fe8f586d227801">42d9b907a refactor!: have a structured IndexOutOfBoundsError type (chaitika)

Pull request description:

  ### Description
  Fixes #267

  ### Notes to the reviewers
  I can rebase to master after #298 is merged to fix fmt errors.

  ### Changelog notice

  ```md
  Added
  - newtype `IndexOutOfBoundsError`

  Changed
  - `PolicyError::IndexOutOfRange` now wraps a `IndexOutOfBoundsError`
  - `SignerError::InputIndexOutOfRange` now wraps a `IndexOutOfBoundsError`
  ```

  ### Checklists

  #### All Submissions:

  * [X] I've signed all my commits
  * [X] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [X] I ran `just p` before pushing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [X] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 42d9b907a18074e53154cea5e2fe8f586d227801

Tree-SHA512: 1ea31ff61554408cccef2c63d0c3147013a

27 of 43 new or added lines in 4 files covered. (62.79%)

6908 of 8145 relevant lines covered (84.81%)

3358.92 hits per line