babelfish-for-postgresql / babelfish_extensions / 17849196517

77%

push

github

Support Same-DB Ownership Chaining for object references inside Procedure/Functions (#4057)

This commit implements the ownership chaining support for object
references inside function/procedure. The basic idea of Ownership chaining is that when
one object references another, and both have the same owner, then permissions
are only checked when the top-level object is accessed.

Core Functionality:
Added support for ownership chaining within the same database for procedures and functions

Key Components Modified:

    Added ownership chain validation in permission checks
    Walker function to mark relations and functions inside view definitions

Implementation:

Walker function to mark relations and functions inside view definitions

Walks through the query parse tree to:

    Mark relations and functions as being inside a view context
    For relations:
        Set checkAsUser to the view_owner when it matches the relation's owner,
        enabling permission checking to pass at the executor stage (ownership chaining)
    For procedures/functions:
        Store the view_owner in the parentOwnerId field to support
        procedure/function-specific ownership chaining logic
        during permission checks at the executor stage

Task: BABEL-6030
Engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/616

Signed-off-by: Harsh Lunagariya <lunharsh@amazon.com>
Co-authored-by: pranav jain <pranav23iitd@gmail.com>

77 of 79 new or added lines in 4 files covered. (97.47%)

51158 of 66874 relevant lines covered (76.5%)

382631.55 hits per line