babelfish-for-postgresql / babelfish_extensions / 17826501005

78%

BABEL_6_X_DEV: 78%

Build Type

push

github

Committed by web-flow

Commit Message

fixing revoke permission from object behaviour (#3994)

Problem : When we grant some permissions on schema and object in that schema to a user, in that case regardless of permission that we are trying to revoke, in babelfish we never really execute the revoke and just update the catalog.
Fixed the issue by adding a permission check in the privilege check function so that we execute revoke when the schema permission and object permission are not common.
Secondly, we are revoking the permission which are already not granted to the schema, if any permission granted to schema and object both then we won't revoke it, for that we are updating the grant-privileges list in the query tree itself before execution stage.

Issues Resolved
[BABEL-5904]

Signed-off-by: pranav jain <pranav23iitd@gmail.com>

Coverage Stats

80 of 83 new or added lines in 4 files covered. (96.39%)

211 existing lines in 3 files now uncovered.

50982 of 66695 relevant lines covered (76.44%)

384358.01 hits per line