gofogo / k8s-sigs-external-dns-fork / 17801852987

81%

push

github

feat(cli): migrate kingpin to cobra - dual parity (#5836)

* feat(cli): add Cobra binder and backend switch

* add FlagBinder with Kingpin and Cobra implementations
* support --cli-backend and EXTERNAL_DNS_CLI (default: kingpin)
* add tests for binders and CLI switch

Refs: #5379

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>

* feat(cli): centralize flag registration and add Cobra parity

Started moving CLI flag registration into a common binder function,
avoiding duplication between Kingpin and Cobra.

Refs: #5820

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>

* feat(cli): enforce Cobra parity with Kingpin

* Add `regexpValue` and `RegexpVar` to Cobra binder with
  `setRegexpDefault`
* Enforce `--provider` presence and validate against `providerNames
* require at least one `--source` and validate against new
  `allowedSources`
* Expand tests for Kingpin and Cobra

Refs: #5379

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>

* feat(cli): Commit go-lint edits

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>

* feat(cli): add kingpin vs cobra binder parity

* Test parity assertion across binders
* Test Cobra-specific incapabilities (`--no-<flag>` and env vars)
* Deduplicate regexp flag handling

Refs: #5379

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>

* feat(cli): Rebuild flags documentation

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>

---------

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>

281 of 281 new or added lines in 2 files covered. (100.0%)

15726 of 20034 relevant lines covered (78.5%)

754.93 hits per line