tari-project / tari / 17797323772
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 706
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 59.9% (-0.1%) from 60.049%
17797323772

push

github

web-flow 
feat: add timeouts to health check (#7482)

Description
---
- This PR fixes an interlock in the health check whereby either
discover-peer or ping-peer locks up and does not return. This culminated
in the health check being interlocked for the remainder of the base
node's uptime.
- The discover-peer and ping-peer health checks are now run in parallel.
- The ping-peer health check is now preceded by a dial-peer to ensure we
have a connection before we proceed.
- Changed the gRPC `liveness_results` in the `GetNetworkState` method to
return `ms` instead of `s` and documented it as such; this was
previously undocumented. When the network is well connected, discovery
and ping latencies would be less than `1 s`, resulting in zero values to
be returned.

Fixes #7380.

Motivation and Context
---
See #7380.

How Has This Been Tested?
---
- System-level testing (`c::bn::tari_pulse` logged at least trace level)
- When running the gRPC `GetNetworkState` method, `liveness_results`
should not be an empty array if seed peers are contactable.

What process can a PR reviewer use to test or verify this change?
---
Code review.
System-level testing (to verify in the log files change
`c::bn::tari_pulse` to at least debug level).

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [ ] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [X] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
BREAKING CHANGE: Changed the gRPC `liveness_results` in the
`GetNetworkState` method to return `ms` instead of `s` and documented it
as such; this was previously undocumented.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Fe... (continued)

0 of 161 new or added lines in 1 file covered. (0.0%)

160 existing lines in 14 files now uncovered.

73181 of 122172 relevant lines covered (59.9%)

592638.29 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
161
0.0
 0.0% base_layer/core/src/base_node/tari_pulse_service/mod.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
0.0
 0.0% base_layer/core/src/base_node/tari_pulse_service/mod.rs
1
82.98
 -2.13% base_layer/core/src/proof_of_work/sha3x_pow.rs
1
91.54
 -0.77% base_layer/transaction_components/src/consensus/consensus_encoding/hashing.rs
2
52.99
 -0.44% base_layer/core/src/validation/helpers.rs
2
81.3
 -0.81% comms/core/src/connectivity/peer_health.rs
3
78.28
 -0.65% base_layer/transaction_components/src/validation/aggregate_body/aggregate_body_internal_validator.rs
3
90.05
 -0.75% comms/core/src/multiplexing/yamux.rs
4
8.33
 -5.56% base_layer/core/src/chain_storage/block_add_result.rs
4
55.7
 -1.69% base_layer/transaction_key_manager/src/storage/sqlite_db/mod.rs
8
44.57
 0.16% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
8
86.22
 -3.15% base_layer/transaction_components/src/validation/helpers.rs
9
51.76
 -10.59% base_layer/core/src/validation/block_body/block_body_full_validator.rs
13
59.58
 -5.42% base_layer/core/src/validation/aggregate_body/aggregate_body_chain_validator.rs
101
82.93
 -16.42% base_layer/core/src/validation/block_body/test.rs
Jobs
ID Job ID Ran Files Coverage
1 17797323772.1 706
59.9
 GitHub Action Run
Source Files on build 17797323772