reactivando / use-pubsub-js / 17783295596

99%

master: 80%

push

github

fix(hooks): correct useSubscribe handler updates (#41)

The useSubscribe hook was not correctly handling updates to the handler function. When a component using the hook re-rendered with a new handler, the hook would not unsubscribe the old handler, leading to stale closures and memory leaks.

This commit fixes the issue by using a ref to store the latest handler function and ensuring that the subscription always calls the most current handler. It also properly unsubscribes the old handler when the component unmounts or when the dependencies change.

A test case has been added to verify that the fix works as expected.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

26 of 27 branches covered (96.3%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 1 file covered. (100.0%)

120 of 121 relevant lines covered (99.17%)

8.31 hits per line