tarantool / tarantool / 17767323323

88%

Build Type

push

github

Committed by locker

Commit Message

box: don't use txns on snapshot recovery if possible

We don't basically need transactions when recovering from snapshot,
except for when recovering system spaces. Another exception is client
recovery triggers. So let's avoid using transactions if recovery triggers
are disabled. This gives a significant performance improvement.

Part of #11452

============================
= Performance test results =
============================

Recovery performance is evaluated using below perf test setup with compat
option 'old' or 'new'. The test does not work with 1.10.5 so it was
manually patched to remove non existing options and modules.

```
tarantool perf/lua/recovery.lua \
      --row_count 10000000 --column_count 10 --recovery_count 5 \
      --preload_script "require('compat').box_recovery_triggers_deprecation = 'new'"
```

Run                | Perf, krps |
---------------------------------|
master triggers on  |    710     |
---------------------------------|
master trigger off  |    1060    |
---------------------------------|
1.10.5              |    1315    |

So 1.10.5 is 85% faster then current master with triggers. Disabling
triggers give master 49% boost, so that 1.10.5 is only 24% faster then
master.

NO_CHANGELOG=performance
NO_DOC=performance

Run Details

71301 of 125127 branches covered (56.98%)

46 of 53 new or added lines in 4 files covered. (86.79%)

16 existing lines in 10 files now uncovered.

104808 of 119600 relevant lines covered (87.63%)

1371962.97 hits per line