goto / guardian / 17722675209

69%

main: 66%

push

github

feat: implement approvals summaries (#218)

* feat: implement approvals summaries

* feat: add approval summaries API and update filter fields

Introduces new endpoints for generating approval summaries, including domain models and proto definitions. Refactors approval filter fields, replacing 'ApproverStepNames' with 'StepNames' in requests and updates related code, adapters, and proto files. Removes unused summary proto messages and aligns implementation with new summary structure.

* Make JSON fields omitempty and refactor summary filter

Added 'omitempty' to JSON tags in Summary and SummaryGroup structs to omit empty fields in output. Renamed applyFilterForSummary to applyListApprovalsSummaryFilter for clarity and updated its usage. Improved groupBy handling in GenerateListApprovalsSummary to avoid adding empty group keys.

* Fix summary group appending logic in approval repository

Summary groups are now only appended when groupBys is non-empty, preventing empty group entries in the result. This ensures the summary output is consistent with the intended grouping logic.

* Change summary total fields from int64 to int32

Updated all relevant structs, protobuf definitions, and OpenAPI specs to use int32 instead of int64 for 'total' fields in summary-related types. This ensures consistency across the API, domain models, and storage layers.

* Implement GenerateListApprovalsSummaries logic

Added the full implementation for the GenerateListApprovalsSummaries gRPC handler, including filter extraction, summary generation, and response population. The response now includes the generated summaries and total count.

* Refactor summary filter naming in approval APIs

Renamed fields and types in SummaryFilter from singular to plural forms (e.g., AppealFilter to AppealsFilter) across protobuf definitions, Go generated code, and handler logic for consistency and clarity. Updated Makefile to use a new PROTON_COMMIT. This change improves naming consistency and ... (continued)

21 of 242 new or added lines in 4 files covered. (8.68%)

11336 of 16321 relevant lines covered (69.46%)

4.59 hits per line