tari-project / tari / 17672374846
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 706
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.97% (+0.02%) from 60.947%
17672374846

push

github

web-flow 
fix: peer_db null update where none should be written as null (#7489)

Description
---
Fixed peer_db update where a `value = None` was ignored in the update
set instead of changing the value to `null` in the database. This caused
higher-level logic that depended on `null` to represent something to
fail.

Fixes #7469.

Motivation and Context
---
See above.

This data extract shows data for `last_failed_reason` where it should
have been cleared, because `last_seen` has been updated recently (active
connections).

node_id | address | last_seen | last_failed_reason
-- | -- | -- | --
ed1cc6f6b4fdd0cb71cf1c06b8 |
/onion3/xvca7s6ls5jy2e2yblofve5l5oukgvf4c5lbt6ls3a7ksezjl4rhfmyd:18141 |
2025/09/10 14:38:17 | Dial timeout dialing
/onion3/xvca7s6ls5jy2e2yblofve5l5oukgvf4c5lbt6ls3a7ksezjl4rhfmyd:18141
after 60.00s
ab2fad12f448628436bcbe98d1 | /ip4/51.83.4.85/tcp/18189 | 2025/09/10
14:49:17 | Transport error for /ip4/51.83.4.85/tcp/18189: An attempt was
made to access a socket in a way forbidden by its access permissions.
(os error 10013)
5090e6ee18fd7353462b3dadcd |
/onion3/i5drghe3xlbcrpi2ejgifxrlfvddqikwiqrbuur6kzb5fdx6ufisvtid:18141 |
2025/09/10 14:49:17 | Dial timeout dialing
/onion3/i5drghe3xlbcrpi2ejgifxrlfvddqikwiqrbuur6kzb5fdx6ufisvtid:18141
after 60.00s


How Has This Been Tested?
---
Added a unit test to confirm updates are working as expected.
System-level testing on esmeralda, where this is most apparent.

What process can a PR reviewer use to test or verify this change?
---
Code review.
System-level testing on esmeralda.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
about it carefully. -->


Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, i... (continued)

91 of 99 new or added lines in 2 files covered. (91.92%)

23 existing lines in 9 files now uncovered.

74343 of 121933 relevant lines covered (60.97%)

223516.54 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
8
90.72
 0.13% comms/core/src/peer_manager/storage/database.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
17.44
 -1.16% base_layer/core/src/chain_storage/error.rs
1
75.64
 -1.28% base_layer/node_components/src/blocks/chain_block.rs
1
75.98
 -0.22% comms/core/src/connection_manager/peer_connection.rs
1
90.05
 -0.25% comms/core/src/multiplexing/yamux.rs
2
81.2
 -0.3% comms/core/src/protocol/rpc/client/mod.rs
4
56.72
 -0.13% base_layer/core/src/chain_storage/lmdb_db/lmdb_db.rs
4
55.7
 -1.69% base_layer/transaction_key_manager/src/storage/sqlite_db/mod.rs
4
55.92
 0.21% comms/core/src/connectivity/manager.rs
5
60.48
 -0.27% comms/dht/src/connectivity/mod.rs
Jobs
ID Job ID Ran Files Coverage
1 17672374846.1 706
60.97
 GitHub Action Run
Source Files on build 17672374846