stacklok / toolhive / 17668088396

58%

Build Type

push

github

Committed by web-flow

Commit Message

Fix timeout handling for large Docker image pulls (#1847)

Add dedicated timeout context for image retrieval operations to handle
large Docker images that take longer than the default API timeout.

Previously, when pulling images over 1GB that exceeded the 60-second
API timeout, the system would incorrectly report 'image not found in
registry' instead of indicating a timeout error. This made debugging
difficult as the error message was misleading.

Changes:
- Add imageRetrievalTimeout constant set to 10 minutes
- Create dedicated context with longer timeout for image pulls
- Check for context.DeadlineExceeded to detect timeouts
- Return clear timeout error messages instead of 'image not found'
- Handle both DeadlineExceeded and Canceled context errors

This ensures users get accurate error messages when image pulls timeout
due to large file sizes or slow connections.

Fixes #1665

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>

Run Details

5 of 31 new or added lines in 2 files covered. (16.13%)

21 existing lines in 1 file now uncovered.

12340 of 30812 relevant lines covered (40.05%)

17.14 hits per line