reactivando / validations-br / 17666370613

91%

master: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(validations): Correct validation logic and test data (#48)

* fix(validations): correct validation logic and test data

A recent refactor introduced several bugs in the validation functions and left the test suite with incorrect data. This commit addresses these issues across multiple validation modules.

- `validateCNPJ`: Re-implemented the validation logic to correctly use the standard algorithm with two sets of weights. The generic `mod11` function was not suitable. Corrected the test data to move an invalid CNPJ to the failing test case.
- `validatePIS`: Corrected the check digit calculation logic and updated the test data with algorithmically valid PIS numbers.
- `validateCNH`: Added a missing length check and corrected the DV2 calculation. Updated the test suite to move invalid CNHs to the failing test case.
- `validatePhone`: Updated the validation for 8-digit landlines to accept a wider range of valid starting digits (including 6 and 8).
- `validateIE`:
  - For Goiás (GO), added '20' to the list of valid IE prefixes.
  - For Tocantins (TO), rewrote the validation logic to correctly handle different formats based on length and embedded prefixes.
- Removed the `cpf-cnpj-validator` dependency that was added for debugging purposes.

All test suites now pass.

* chore: Fix linting errors

This commit addresses all the linting errors reported by the linter.
- Fixed Prettier formatting issues in several files.
- Replaced a `for...of` loop with `forEach` to comply with the configured rules.
- Addressed a `no-unused-vars` error in a type definition with an `eslint-disable` comment.

---------

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Run Details

182 of 216 branches covered (84.26%)

Branch coverage included in aggregate %.

55 of 61 new or added lines in 8 files covered. (90.16%)

20 existing lines in 14 files now uncovered.

578 of 607 relevant lines covered (95.22%)

12.64 hits per line