OGGM / oggm / 17612829718

85%

master: 84%

push

github

Adding SfcTypeTIModel (#1801)

* feat: child DailyTIModel, refactor MonthlyTIModel

Adds the DailyTIModel from OGGM/massbalance-sandbox.
Relies on subclass' methods instead of if statements in parent.
No breaking changes!

The output from DailyTIModel is slightly different as it switches to the
Julian year for calculating melt_f (mean percentage difference -0.23%).

* tests(models): add template for DailyTIModel

Some tests are skipped as daily data is not yet implemented into
ref_mb_data.

* feat(shop): download W5E5 data at daily resolution

Links ``process_w5e5_data`` to ``process_gswp3_w5e5_data_daily`` to
preserve workflow for other daily resolution datasets. Data is currently
pulled from ~dtcg until it is available on OGGM.

Refactors:
  - Duplicated code
  - URL checking in conftest
Removes:
 - Unused gradient computations, unused imports.

Refs: #1750

* feat: convert between hydro/julian dates

Adds support for converting between hydro/julian date arrays and vice
versa, used for daily W5E5 data.

Refs: #844, #1349

* refactor(models): MB models switch more cleanly between resolutions

Fixes missing ``climate_historical_daily`` file and monthly data passed
to daily model.

* refactor(shop): drop hydroyear support, tests

Removes support for hydroyear conversion as data now follow Julian
calendar.

Adds tests for W5E5 shop.

Bugs: Some statistical functions do not yet support daily data.

* fix(massbalance): incorrect dimensions for daily climate data

* feat(massbalance): daily specific mass balance output

Adds daily specific mass balance to output via ``get_specific_mb_daily``.

Daily MB is not fully integrated with the rest of OGGM, nor with leap years.

Bug: ``get_annual_mb`` and hence ``get_specific_mb`` skips the last month of
data.

* fix(massbalance): W5E5 shop now downloads last month of data

Fixes bug where the last month of data was not downloaded from the shop, which
then affected annual mass balance calculations.

* fix: specific... (continued)

3784 of 5284 branches covered (71.61%)

313 of 346 new or added lines in 3 files covered. (90.46%)

12923 of 15246 relevant lines covered (84.76%)

3.74 hits per line