tari-project / tari / 17605410931

62%

Build Type

push

github

Committed by web-flow

Commit Message

fix: ambiguous seedstrap warning log (#7483)

Description
---
Fixed a seedstrap warning log whereby the log would state _SeedStrap:
**Failed to contact any seed nodes** or retrieve new peers._ without
giving proper feedback about the real issue. The log message tells two
different stories, and we would not know which to believe.

This PR changes the single warning message into these two:
- `"SeedStrap: Failed to communicate with any seed nodes."`
- `"SeedStrap: Communicated with {} seed nodes but did not retrieve any
peers."`

See related issue #7469, where this behaviour was picked up.

Motivation and Context
---
Analysing a similar log file to the problem described in issue #7469, it
is apparent that the seed peers were contacted successfully, but that
they did not return any peer information:
```
2025-09-08 14:30:39.753172000 [comms::dht::network_discovery::seed_strap] [Thread:2313251] INFO  SeedStrap: Attempt 2/2: Seed peer 'ab2fad12f448628436bcbe98d1' returned an empty peer list. Disconnecting.
2025-09-08 14:30:39.756704000 [comms::dht::network_discovery::seed_strap] [Thread:2313257] INFO  SeedStrap: Attempt 1/2: Seed peer 'ace05844c9c9723a8597682be3' returned an empty peer list. Disconnecting.
2025-09-08 14:30:39.757084000 [comms::dht::network_discovery::seed_strap] [Thread:2313257] WARN  SeedStrap: Failed to contact any seed nodes or retrieve new peers.
2025-09-08 14:30:39.757122000 [comms::dht::network_discovery] [Thread:2313257] WARN  SeedStrap round was not successful. Waiting before next attempt.
```

How Has This Been Tested?
---
Encountered this condition locally with esmeralda during system-level
testing and could replicate it with the new PR.

What process can a PR reviewer use to test or verify this change?
---
Code review.

<!-- Checklist -->
<!-- 1. Is the title of your PR in the form that would make nice release
notes? The title, excluding the conventional commit
tag, will be included exactly as is in the CHANGELOG, so please think
... (continued)

Run Details

0 of 32 new or added lines in 1 file covered. (0.0%)

59 existing lines in 9 files now uncovered.

74325 of 121924 relevant lines covered (60.96%)

294348.05 hits per line