17575631418
73%

Ran 09 Sep 2025 07:59AM UTC

Jobs 1

Files 983

Run time 2min

Badge

Embed ▾

Committed 09 Sep 2025 07:48AM UTC coverage: 72.93% (+0.01%) from 72.917%

Build # 17575631418

Build Type

push

github

Committed by

web-flow

Commit Message

Add RataDie::in_well_behaved_astronomical_range(), use to avoid panics (#6876)

Attempting to address https://github.com/unicode-org/icu4x/issues/4917,
https://github.com/unicode-org/icu4x/issues/5068,
https://issues.chromium.org/issues/439624688.

Related: https://github.com/unicode-org/icu4x/issues/5778

https://github.com/tc39/proposal-temporal/issues/2869 has told us that
we are allowed to break calendar-internal invariants outside of the
useful range of the calendar.

We currently hit debug assertions for some of these dates. This patches
it up by

This is a partial PR, I haven't fixed all of the assertions. We'll
likely have to make the function in calendrical_calculations pub+hidden
(or make a copy in `icu_calendar`) and use it.

I would like feedback on the approach.

Run Details

23 of 38 new or added lines in 5 files covered. (60.53%)

9 existing lines in 7 files now uncovered.

60523 of 82988 relevant lines covered (72.93%)

469784.62 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	67.54	0.0%	utils/calendrical_calculations/src/islamic.rs
2	86.57	-0.69%	components/calendar/src/cal/chinese_based.rs
2	78.45	1.54%	components/calendar/src/cal/hijri.rs
2	70.54	-1.02%	components/calendar/src/provider/chinese_based.rs
8	86.52	-2.53%	utils/calendrical_calculations/src/chinese_based.rs

Uncovered Existing Lines

Lines	Coverage	∆	File
1	84.03	-0.69%	components/calendar/src/cal/gregorian.rs
1	77.42	0.0%	components/datetime/src/provider/pattern/hour_cycle.rs
1	91.94	-0.2%	components/datetime/src/provider/pattern/reference/parser.rs
1	97.4	0.0%	utils/calendrical_calculations/src/astronomy.rs
1	82.02	-0.44%	utils/zerotrie/src/reader.rs
2	70.54	-1.02%	components/calendar/src/provider/chinese_based.rs
2	41.88	-0.2%	components/datetime/src/pattern/names.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	17575631418.1	09 Sep 2025 07:59AM UTC	983	72.93	GitHub Action Run

unicode-org / icu4x / 17575631418
73%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 17575631418

unicode-org / icu4x / 17575631418 73%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 17575631418

unicode-org / icu4x / 17575631418
73%

README BADGES
x