unicode-org / icu4x / 17561101817

73%

Build Type

push

github

Committed by web-flow

Commit Message

zoneinfo64: Add UtcOffsetSeconds, remove icu_time dep (#6914)

We only use `icu_time` for `UtcOffset`. This is a large extra dependency
(V8 currently doesn't pull it in otherwise), so it would be nice to not
need it.

Open to being convinced that we should use this crate anyway. In the
long term V8 will likely be using icu_time anyway. But allowing clients
to have the option seems good.

I see zoneinfo64 as a low level crate; and icu_time as a higher level
one that you might pair with it for a full-fledged timezone
implementation.

zoneinfo64 does depend on `icu_locale_core` for `Region` but that's a
smaller dep tree.

Run Details

20 of 22 new or added lines in 3 files covered. (90.91%)

5 existing lines in 5 files now uncovered.

60498 of 82968 relevant lines covered (72.92%)

469694.09 hits per line