bitcoindevkit / bdk-cli / 17560193808

8%

push

github

Merge bitcoindevkit/bdk-cli#208: Update `compile` command to support creating taproot descriptors

<a class=hub.com/bitcoindevkit/bdk-cli/commit/3bcec61d8721b1f5a863eb6f3e1be146bc0bf54d">3bcec61d8 feat(compile): add tr option for compile cmd (Vadim Anufriev)

Pull request description:

  ### Description
  Resolves #204.

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers
  For creating the tr descriptor, I used the NUMS pubkey proposed in [BIP-341](https://github.com/bitcoin/bips/blob/master/bip-0341.mediawiki#constructing-and-spending-taproot-outputs).

  There is [discussion](https://github.com/rust-bitcoin/rust-bitcoin/issues/1322) about adding NUMS key to `rust-bicoin`, we can use it in the future from there.

  Also there is [BIP draft](https://github.com/bitcoin/bips/pull/1746) for new descriptor key expression `unspendable()` for exacly this use case - we will simply use descriptor `tr(unspendable(), TREE)`.

  ## Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk-cli/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [ ] I've added docs for the new feature
  * [ ] I've updated `CHANGELOG.md`

ACKs for top commit:
  notmandatory:
    utACK 3bcec61d8721b1f5a863eb6f3e1be146bc0bf54d

Tree-SHA512: bd20091377252120b611e4dd76648ed5ecd

59 of 67 new or added lines in 2 files covered. (88.06%)

105 of 1217 relevant lines covered (8.63%)

0.17 hits per line