FlexMeasures / flexmeasures / 17556339436

74%

Build Type

push

github

Committed by web-flow

Commit Message

Chore: stop using our API internally (#1683)

* stop using InternalApi() on account page

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* we forgot to include the account API in the docs

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add more spellings I don't want redlined

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* move endpoint logic for assets (create, patch, delete) into services

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* UI views for assets stop calling the API internally

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* remove mock API calls from asset UI tests, reorder: create asset test before edit test

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* remove two functions we don't need no longer

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* fix calls to renamed test function

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* User views do not call InternalAPI, not only admins can now visit the page for a user, one new service utility now shared by API and UI views, removed mocks from tests

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* add changelog entry

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* actually remove InternalApi class

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* no need (and misleading) to call check_access() in render_user(). Both functions which use this already do their own check_access() call.

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

---------

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

Run Details

1233 of 1829 branches covered (67.41%)

Branch coverage included in aggregate %.

86 of 110 new or added lines in 8 files covered. (78.18%)

7 existing lines in 5 files now uncovered.

8958 of 12188 relevant lines covered (73.5%)

5.88 hits per line