tari-project / tari / 17549972632
62%

DEFAULT BRANCH: development
Ran
Jobs 1
Files 706
Run time 3min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 60.917% (-0.2%) from 61.111%
17549972632

push

github

web-flow 
feat: wallet multisignature feature (#7481)

Description
---
This PR introduces support for multisignature (multisig) functionality
across the CLI and gRPC interfaces.

Cli methods provided
- SignMessage - Needed in Tari_Universe to sign messages 
- SignScriptMessage- Needed in tari_universe to sign script message
- PrepareDepositMultisigTransaction - Test purpose only. Create
transaction for converting normal utxo into multisign one. Without
signing it (needed in tari_universe for offline signing)
- PrepareWithdrawMultisigTransaction - Test purpose only. Create
transaction for converting multisig utxo into normal one. Without
signing it (needed in tari_universe for offline signing)
- SignOneSidedDepositMultisigTransaction - Sign the Prepared deposit
transaction (for offline signing in tari_universe).
- SignOneSidedWithdrawMultisigTransaction - Sign the Prepared withdraw
transaction (for offline signing in tari_universe).
- CreateMultisigUtxo - It is the same as
PrepareDepositMultisigTransaction /
SignOneSidedDepositMultisigTransaction but it can be called only from
cli.(won't work with offline signing)
- GetMultisigUtxoData - Return Data from utxo that are needed for
multisig (challenge / public_offset_key).
- SendMultisigUtxo - It is the same as
PrepareWithdrawMultisigTransaction /
SignOneSidedWithdrawMultisigTransaction but it can be called only from
cli.(won't work with offline signing)


GRPC methods
- PrepareDepositMultisigTransaction 
- PrepareWithdrawMultisigTransaction - transaction for converting
multisig utxo into normal one. Without signing it (needed in
tari_universe for offline signing)

Motivation and Context
---

How Has This Been Tested?
---
Written unit test and manually both from CLI and from tari universe
offline signing.

What process can a PR reviewer use to test or verify this change?
---
The change can be tested from the wallet using Docker.

**1. Create a multisignature UTXO (replace with your own data):**

```
docker compose ... (continued)

847 of 1880 new or added lines in 17 files covered. (45.05%)

8 existing lines in 5 files now uncovered.

73757 of 121077 relevant lines covered (60.92%)

296113.71 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
0.0
 base_layer/wallet/src/transaction_service/multisig/types.rs
2
0.0
 0.0% base_layer/wallet/src/output_manager_service/storage/output_source.rs
3
96.93
 -0.21% infrastructure/tari_script/src/script.rs
6
8.34
 -0.07% base_layer/wallet/src/output_manager_service/storage/sqlite_db/output_sql.rs
8
90.79
 5.48% base_layer/wallet/src/transaction_service/offline_signing/one_sided_signer.rs
14
69.71
 -2.32% base_layer/transaction_components/src/key_manager/wrapper.rs
14
88.77
 2.7% base_layer/wallet/src/transaction_service/offline_signing/offline_signer.rs
17
58.54
 base_layer/wallet/src/transaction_service/multisig/script.rs
27
12.86
 4.75% base_layer/wallet/src/transaction_service/offline_signing/models.rs
30
56.74
 0.61% base_layer/transaction_components/src/key_manager/inner.rs
47
0.0
 0.0% base_layer/wallet/src/output_manager_service/handle.rs
47
0.0
 0.0% base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
100
0.0
 0.0% base_layer/wallet/src/output_manager_service/service.rs
129
0.0
 0.0% base_layer/wallet/src/transaction_service/handle.rs
287
0.0
 base_layer/wallet/src/transaction_service/multisig/session.rs
301
0.0
 0.0% base_layer/wallet/src/transaction_service/service.rs

Uncovered Existing Lines

Lines Coverage ∆ File
1
93.89
 -0.17% base_layer/core/src/proof_of_work/monero_rx/merkle_tree.rs
1
0.0
 0.0% base_layer/wallet/src/output_manager_service/handle.rs
1
0.0
 0.0% base_layer/wallet/src/utxo_scanner_service/utxo_scanner_task.rs
2
12.86
 4.75% base_layer/wallet/src/transaction_service/offline_signing/models.rs
3
0.0
 0.0% base_layer/wallet/src/output_manager_service/service.rs
Jobs
ID Job ID Ran Files Coverage
1 17549972632.1 706
60.92
 GitHub Action Run
Source Files on build 17549972632