c-ares / c-ares / 17530642883

92%

push

github

fix conversion of invalid service to port number in ares_getaddrinfo() (#1029)

**Problem Description:**

ares_getaddrinfo() does not return ARES_ESERVICE as it is supposed to
for unknown or invalid *service* parameters.
It returns port 0 instead.


**Causes:**
- strtoul() returns 0 and no error if the string does not contain a
number.
- strtoul() returns no error if the string begins with a number followed
by other characters.
- strtoul(..., 0) accepts hexadecimal and octal port numbers, which
POSIX getaddrinfo() does not.

Signed-off-by: Uwe Salomon @nixblik

18 of 21 new or added lines in 2 files covered. (85.71%)

22601 of 24650 relevant lines covered (91.69%)

11821.6 hits per line