Camelcade / Perl5-IDEA / #525521672

76%

Build Type

push

github

Committed by hurricup

Commit Message

#2349 #CAMELCADE-2253 Improved perl names cache updating

- Update maps only if they did change
- Wipe resolve cache if update performed

The theory is that cache updates while resolve results are cached. But after context changes, things may change as well.

This solution is not perfect but should improve the situation. Race is still possible between update and reset. Also, lexer/parser may cache sets.

Afraid that this change may cause performance degradation, caused by resolve cache wiping. But unfortunately we don't have a performance tests. We could make it more precise and wipe only subs cache, but perl is too flexible and may do some really funny tricks.

Fixes #2349
#CAMELCADE-2253 #Fixed

Run Details

14739 of 22631 branches covered (65.13%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

31069 of 37760 relevant lines covered (82.28%)

0.82 hits per line