andygout / theatrebase / 1093
100%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 110
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1093

push

travis-ci

web-flow 
Refactor codebase (#139)

* Rename: Form error partial

* Rename: View partials folder as 'application'

* Amend: Form error wording

* Amend: HTML spacing in error page home link partial

* Amend: Head alert + form alert height to min-height attribute

* Use: Patch not post for update in controller tests

* State: Production id as edit param in controller test

* Correct: Wording of title validation in production model tests

* Correct: Description wording of edit tests in production controller tests

* Remove: id attribute when checking if production exists in production feature delete test

* Amend: Spacing of curly braces in production controller tests

* Extract: Production feature show tests into separate index tests

* Amend: Theatre + user show feature tests description wording

* Use: Single quotes for dates_tbc_note value in en.yml

* Amend: link_markup method argument name from 'id' to more semantic 'identifier'

* Relocate: Controller test files into separate subdirectories

* Tighten: Presentation of associations files

* Remove: ActiveModel::Validations from production model

* Refactor: Methods to acquire browser tab text

* Use: Constants for model names in controllers

* Remove: add_error method in generate URL validator

* Consolidate: Constants into single helper module

* Amend: Spacing in validator files

* Correct: Argument syntax using 'exists?' method in production + theatre delete feature tests

* Amend: Listing table th + td padding

* Share: get_views_components method across requisite controllers

* Share: get_forms_components method across requisite controllers

* Extract: get_status_edit_components into before_action for admin + suspension status controllers

* Extract: get_user into before_action for admin + suspension status controllers

* Locate: Production controller get_show_components functionality directly into show method

* Locate: Admin + suspension status controller call to get_status_edit_components in edit method

* Use: Parentheses for before_action methods

* Abbreviate: get_production_by_id_url method name -> get_production

* Add: GetUserHelper module to share between user + status controllers

* Extract: Productions::ViewsComponentsHelper -> Shared::ViewsComponentsHelper (given now used by theatre controller)

* Rename: get_views_components method -> get_content_header

* Make: StatusHelper module get_status_edit_components method private

* Set: Model (user) as constant at top of status helper

* Amend: get_theatre_by_url method -> get_theatre

* Share: get_browser_tab method between theatre + user controllers

* Consolidate: Productions controller get_new_production + get_production methods into single method

* Refactor: before_actions methods

* Extract: User controller private user validation methods into before_actions

* Implement: Flash success messages via shared method

4165 of 4168 relevant lines covered (99.93%)

45.42 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1093.1 (2.2.1) 0
99.93
 Travis Job 1093.1
Source Files on build 1093
Detailed source file information is not available for this build.