zhmcclient / zhmc-prometheus-exporter / test-1936

38%

Build Type

push

github

Committed by andy-maier

Commit Message

Improved caching with a consolidated new resource cache

Details:

* Replaced the three existing caches:
  - ZHMCUsageCollector.uri2resource dict
  - ZHMCUsageCollector.resources dict
  - ResourceCache class
  with a single consolidated resource cache:
  - ResourceCache class
  This is a new implementation that optimizes the retrieval, storing
  and enablement of auto-update of resource objects to the minimum.

  Only resources for enabled metric groups and only for the target CPCs
  are retrieved. In order to detect whether resource URIs returned by
  the HMC metric service are for target CPCs, all of them are stored
  in the cache as well.

* This required changing several interfaces.

* Improved the handling of object access permissions that are
  missing. Right now, resources of metrics may be inaccessible,
  which causes their metrics not to be exported. However, the
  parent resources of accessible resources of metrics also must
  be accessible.

* Adjusted the testcases in test_all.py to the changed interfaces
  and new resource cache.

Signed-off-by: Andreas Maier <maiera@de.ibm.com>

Run Details

163 of 591 new or added lines in 2 files covered. (27.58%)

9 existing lines in 1 file now uncovered.

582 of 1539 relevant lines covered (37.82%)

3.61 hits per line